From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [RFC] lib/librte_ether: add a return value for MAC
	set ops
Date: Wed, 23 May 2018 00:47:36 +0200
Message-ID: <5363348.Zb8vDSmybQ@xps>
References: <1516848417-77912-1-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, olivier.matz@6wind.com
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7F4F420BD
 for <dev@dpdk.org>; Wed, 23 May 2018 00:47:38 +0200 (CEST)
In-Reply-To: <1516848417-77912-1-git-send-email-wenzhuo.lu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/01/2018 03:46, Wenzhuo Lu:
> Setting the default MAC address may fail on many NICs.
> But the ops return void. So, even it failed, RTE changes
> the MAC address and APP doesn't know the failure.
> 
> It's not real patch, just show the idea to add a return
> value for the ops.
> 
> BTW,
> Seems we should do the same thing for
> rte_eth_dev_mac_addr_remove as it also has chance to fail
> in PMD layer.
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Superseded by "ethdev: return diagnostic when setting MAC address"
	http://dpdk.org/commit/caccf8b318