From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 14/18] xen/arm: IRQ: Store IRQ type in arch_irq_desc Date: Fri, 02 May 2014 09:49:50 +0100 Message-ID: <53635C2E.4040909@linaro.org> References: <1398171530-27391-1-git-send-email-julien.grall@linaro.org> <1398171530-27391-15-git-send-email-julien.grall@linaro.org> <1398261881.18537.127.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wg9AI-0007le-D2 for xen-devel@lists.xenproject.org; Fri, 02 May 2014 08:49:54 +0000 Received: by mail-we0-f182.google.com with SMTP id u57so4183822wes.41 for ; Fri, 02 May 2014 01:49:52 -0700 (PDT) In-Reply-To: <1398261881.18537.127.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, Sorry for the delay, for some unknown reason I skipped this mail. On 23/04/14 15:04, Ian Campbell wrote: >> + * CPU0 otherwise we may miss the type if the IRQ type has been >> + * set early. > > what does "set early" mean, how early is early? Initialised before > secondary CPUs were brought up perhaps? Yes. I will replace "set early" by "initialised before secondary CPUs were brought up" > > /* PPIs are included in local_irqs, we copy the IRQ type from > * CPU0 when bringing up secondary cpus in order to pick up any > * configuration done before this CPU came up. For interrupts > * configured after this point this is done in XXX(). I guess you suggest to replace the previous comment by this one, right? > Why is the copying not conditional on CPU!=0? As the CPU were not online (therefore its per_cpu regions is not there) at the time we setup the IRQ we have to unconditionally set the IRQ type. Regards, -- Julien Grall