From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 14/18] xen/arm: IRQ: Store IRQ type in arch_irq_desc Date: Fri, 02 May 2014 10:00:06 +0100 Message-ID: <53635E96.7000800@linaro.org> References: <1398171530-27391-1-git-send-email-julien.grall@linaro.org> <1398171530-27391-15-git-send-email-julien.grall@linaro.org> <1398261881.18537.127.camel@kazak.uk.xensource.com> <53635C2E.4040909@linaro.org> <1399021033.29636.18.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wg9KD-0000S5-QY for xen-devel@lists.xenproject.org; Fri, 02 May 2014 09:00:10 +0000 Received: by mail-wi0-f181.google.com with SMTP id f8so1998181wiw.8 for ; Fri, 02 May 2014 02:00:08 -0700 (PDT) In-Reply-To: <1399021033.29636.18.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 02/05/14 09:57, Ian Campbell wrote: > But CPU0 must have been online when we setup the IRQ. > > IOW if CPU==0 then isn't > desc->arch.type = per_cpu(local_irq_desc, 0)[irq].arch.type; > equivalent to > desc->arch.type = desc->arch.type > > ? Hmmmm yes, I forgot this case. I will update the patch in the next version. -- Julien Grall