Re: [PATCH] libxl: add stdvga video memory setting with upstream qemu

[Fabio Fantoni <fabio.fantoni@m2r.biz>]

Il 02/05/2014 14:24, Ian Campbell ha scritto:
> On Thu, 2014-04-24 at 15:29 +0200, Fabio Fantoni wrote:
>
> Is this change applicable to all versions of qemu which might be used
> with Xen?

vgamem_mb property was added in qemu 1.3 (same for cirrus vga patch), 
xen 4.4 from source use qemu 1.6, and from distributions package is 
newer all case I saw, then FWIK there should be no problems.
Xen 4.4 if I remember good change other important qemu value for hvm 
domUs that require qemu>=1.6.

>
> Stefano,Anthony: Your feedback would be appreciated.
>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>> ---
>>   tools/libxl/libxl_dm.c |    4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
>> index 90f19b7..51ab2bf 100644
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -505,7 +505,9 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
>>   
>>           switch (b_info->u.hvm.vga.kind) {
>>           case LIBXL_VGA_INTERFACE_TYPE_STD:
>> -            flexarray_append_pair(dm_args, "-device", "VGA");
>> +            flexarray_append_pair(dm_args, "-device",
>> +                GCSPRINTF("VGA,vgamem_mb=%d",
>> +                libxl__sizekb_to_mb(b_info->video_memkb)));
>>               break;
>>           case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
>>               flexarray_append_pair(dm_args, "-device",
>