From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:54121 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbaECTkF (ORCPT ); Sat, 3 May 2014 15:40:05 -0400 Message-ID: <53654673.2030504@kernel.org> Date: Sat, 03 May 2014 20:41:39 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Srinivas Pandruvada CC: linux-iio@vger.kernel.org Subject: Re: [PATCH 15/16] iio: hid-sensors: Inclinometer 3D: Raw read support References: <1397863356-2470-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1397863356-2470-15-git-send-email-srinivas.pandruvada@linux.intel.com> In-Reply-To: <1397863356-2470-15-git-send-email-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 19/04/14 00:22, Srinivas Pandruvada wrote: > Added support for raw reading of channel. If the sensor is powered > off, it will turn on for reading value. > > Signed-off-by: Srinivas Pandruvada Applied to the togreg branch of iio.git Thanks > --- > drivers/iio/orientation/hid-sensor-incl-3d.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/iio/orientation/hid-sensor-incl-3d.c b/drivers/iio/orientation/hid-sensor-incl-3d.c > index bf11678..2478f6c 100644 > --- a/drivers/iio/orientation/hid-sensor-incl-3d.c > +++ b/drivers/iio/orientation/hid-sensor-incl-3d.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -110,11 +111,20 @@ static int incl_3d_read_raw(struct iio_dev *indio_dev, > int report_id = -1; > u32 address; > int ret_type; > + s32 poll_value; > > *val = 0; > *val2 = 0; > switch (mask) { > case IIO_CHAN_INFO_RAW: > + poll_value = hid_sensor_read_poll_value( > + &incl_state->common_attributes); > + if (poll_value < 0) > + return -EINVAL; > + > + hid_sensor_power_state(&incl_state->common_attributes, true); > + msleep_interruptible(poll_value * 2); > + > report_id = > incl_state->incl[chan->scan_index].report_id; > address = incl_3d_addresses[chan->scan_index]; > @@ -124,8 +134,11 @@ static int incl_3d_read_raw(struct iio_dev *indio_dev, > HID_USAGE_SENSOR_INCLINOMETER_3D, address, > report_id); > else { > + hid_sensor_power_state(&incl_state->common_attributes, > + false); > return -EINVAL; > } > + hid_sensor_power_state(&incl_state->common_attributes, false); > ret_type = IIO_VAL_INT; > break; > case IIO_CHAN_INFO_SCALE: >