From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752718AbaEHFuc (ORCPT ); Thu, 8 May 2014 01:50:32 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:53140 "EHLO rtits2.realtek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbaEHFua (ORCPT ); Thu, 8 May 2014 01:50:30 -0400 X-SpamFilter-By: BOX Solutions SpamTrap 5.39 with qID s485o1Zl027490, This message is accepted by code: ctloc85258 Message-ID: <536B1C0A.2050001@realsil.com.cn> Date: Thu, 8 May 2014 13:54:18 +0800 From: micky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Ulf Hansson CC: Chris Ball , Lee Jones , Samuel Ortiz , Greg Kroah-Hartman , Dan Carpenter , , "linux-kernel@vger.kernel.org" , linux-mmc , Roger , Wei WANG Subject: Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req" References: <6a8f18cad47244e849adf8a731c621932fa777e0.1398735435.git.micky_ching@realsil.com.cn> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [172.29.41.103] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqand post_req" if need for 3.15 fix. Best Regards. micky. On 04/29/2014 03:36 PM, Ulf Hansson wrote: > On 29 April 2014 03:54, wrote: >> >From: Micky Ching >> > >> >This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. >> > >> >commit did use >> >mutex_unlock() in tasklet, but mutex_unlock() can't used in >> >tasklet(atomic context). The driver need use mutex to avoid concurrency, >> >so we can't use tasklet here, the patch need to be removed. >> > >> >The spinlock host->lock and pcr->lock may deadlock, one way to solve the >> >deadlock is remove host->lock in sd_isr_done_transfer(), but if using >> >workqueue the we can avoid using the spinlock and also avoid the problem. >> > >> >Signed-off-by: Micky Ching > Acked-by: Ulf Hansson > From mboxrd@z Thu Jan 1 00:00:00 1970 From: micky Subject: Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req" Date: Thu, 8 May 2014 13:54:18 +0800 Message-ID: <536B1C0A.2050001@realsil.com.cn> References: <6a8f18cad47244e849adf8a731c621932fa777e0.1398735435.git.micky_ching@realsil.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Ulf Hansson Cc: Samuel Ortiz , Greg Kroah-Hartman , linux-mmc , Chris Ball , "linux-kernel@vger.kernel.org" , Wei WANG , Roger , devel@linuxdriverproject.org, Lee Jones , Dan Carpenter List-Id: linux-mmc@vger.kernel.org Hi Lee Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqand post_req" if need for 3.15 fix. Best Regards. micky. On 04/29/2014 03:36 PM, Ulf Hansson wrote: > On 29 April 2014 03:54, wrote: >> >From: Micky Ching >> > >> >This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. >> > >> >commit did use >> >mutex_unlock() in tasklet, but mutex_unlock() can't used in >> >tasklet(atomic context). The driver need use mutex to avoid concurrency, >> >so we can't use tasklet here, the patch need to be removed. >> > >> >The spinlock host->lock and pcr->lock may deadlock, one way to solve the >> >deadlock is remove host->lock in sd_isr_done_transfer(), but if using >> >workqueue the we can avoid using the spinlock and also avoid the problem. >> > >> >Signed-off-by: Micky Ching > Acked-by: Ulf Hansson >