From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v6 05/10] Clear AC bit in RFLAGS to protect Xen itself by SMAP Date: Thu, 08 May 2014 07:40:56 +0100 Message-ID: <536B431802000078000104B9@mail.emea.novell.com> References: <1399450782-14735-1-git-send-email-feng.wu@intel.com> <1399450782-14735-6-git-send-email-feng.wu@intel.com> <536A009B.20802@citrix.com> <536A37DD020000780000FE3D@mail.emea.novell.com> <536A1EC4.40304@citrix.com> <536AE4A3.6020905@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Feng Wu Cc: Kevin Tian , "ian.campbell@citrix.com" , Andrew Cooper , Eddie Dong , "xen-devel@lists.xen.org" , Jun Nakajima List-Id: xen-devel@lists.xenproject.org >>> On 08.05.14 at 04:02, wrote: >> From: Andrew Cooper [mailto:amc96@hermes.cam.ac.uk] On Behalf Of >> I am not fussed where exactly the STAC goes in the entry point, but >> don't leave a CLAC in the SAVE_ALL. > > Sure, thanks for the suggestion! I will pass 0 to SAVE_ALL. > My point is that ASM_STAC should be deferred as much as possible. There's no point in deferring it as much as possible if you don't CLAC earlier on. In fact I'm inclined to ask to make the SAVE_ALL parameter a tristate, allowing both CLAC and STAC to be done right there. Jan