From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH] ARM: OMAP5: DSS hwmod data Date: Fri, 9 May 2014 11:49:43 +0530 Message-ID: <536C737F.80205@ti.com> References: <1394619996-3525-1-git-send-email-tomi.valkeinen@ti.com> <536B1A9C.7050006@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:37686 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751483AbaEIGVQ (ORCPT ); Fri, 9 May 2014 02:21:16 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Tomi Valkeinen , Tony Lindgren , =?ISO-8859-1?Q?Beno=EEt_Cousson?= , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Paul, On Thursday 08 May 2014 09:31 PM, Paul Walmsley wrote: >> The problem is that we have multiple hwmods which use the same MODULEMODE bit. >> There is no use-counting done when it comes to enabling/disabling modulemode. >> If there was such a thing, we could have provided MODULEMODE flags even for >> the children hwmods. > > Thanks for the summary. This is indeed a long-overdue item for the hwmod > core code. Can you please patch the hwmod core code to add this? I'd > suggest making the use-counting functionality conditional on a hwmod flag > that you can set for all of the DSS hwmods. (Ideally, the core code would > detect that several modules share the same MODULEMODE bits, and > automatically set it for those cases, but that seems a bit too complex for > a first cut.) Sure, I can work on this. Archit From mboxrd@z Thu Jan 1 00:00:00 1970 From: archit@ti.com (Archit Taneja) Date: Fri, 9 May 2014 11:49:43 +0530 Subject: [PATCH] ARM: OMAP5: DSS hwmod data In-Reply-To: References: <1394619996-3525-1-git-send-email-tomi.valkeinen@ti.com> <536B1A9C.7050006@ti.com> Message-ID: <536C737F.80205@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Paul, On Thursday 08 May 2014 09:31 PM, Paul Walmsley wrote: >> The problem is that we have multiple hwmods which use the same MODULEMODE bit. >> There is no use-counting done when it comes to enabling/disabling modulemode. >> If there was such a thing, we could have provided MODULEMODE flags even for >> the children hwmods. > > Thanks for the summary. This is indeed a long-overdue item for the hwmod > core code. Can you please patch the hwmod core code to add this? I'd > suggest making the use-counting functionality conditional on a hwmod flag > that you can set for all of the DSS hwmods. (Ideally, the core code would > detect that several modules share the same MODULEMODE bits, and > automatically set it for those cases, but that seems a bit too complex for > a first cut.) Sure, I can work on this. Archit