From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WihDR-0007Zu-Kj for qemu-devel@nongnu.org; Fri, 09 May 2014 05:35:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WihDM-0003Ox-KN for qemu-devel@nongnu.org; Fri, 09 May 2014 05:35:41 -0400 Received: from mail.emea.novell.com ([130.57.118.101]:33351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WihDL-0003JG-Vr for qemu-devel@nongnu.org; Fri, 09 May 2014 05:35:36 -0400 Message-Id: <536CBD840200007800010D2D@mail.emea.novell.com> Date: Fri, 09 May 2014 10:35:32 +0100 From: "Jan Beulich" References: <1399625235-8216-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1399625235-8216-1-git-send-email-arei.gonglei@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Subject: Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: weidong.huang@huawei.com, Ian.Campbell@citrix.com, hanweidong@huawei.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, fabio.fantoni@m2r.biz, johannes.krampf@googlemail.com, kevin@koconnor.net, mst@redhat.com, anthony.perard@citrix.com, Gaowei >>> On 09.05.14 at 10:47, wrote: > From: Gonglei >=20 > In Xen platform, after using upstream qemu, the all of pci devices > will show hotplug in the windows guest, no matter whether they can > be hotpluged. It is unfriendly. The PCI devices that can not be > hotpluged are hidden by modifing the DSDT entries of PCI slots when = runtime. >=20 > This is done by: > - Rename _EJ0 methods for PCI slots in DSDT to EJ0_:note that > this has the same checksum, but is ignored by OSPM. > - At compile time, look for these methods in ASL source, > find the matching AML, and store the offsets of these methods > in a table named aml_ej0_data. > - At run time, go over aml_ej0_data, check which slots not support > hotplug and patch the ACPI table, replacing _EJ0 with EJ0_. I think you mistakenly sent this to qemu-devel instead of xen-devel. And it also seem pretty pointless to send a v4 without addressing all comments you got on v3. Jan