From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753645AbaKXQzg (ORCPT ); Mon, 24 Nov 2014 11:55:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54799 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbaKXQze (ORCPT ); Mon, 24 Nov 2014 11:55:34 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1416830320.25352.9.camel@dhcp-9-2-203-236.watson.ibm.com> References: <1416830320.25352.9.camel@dhcp-9-2-203-236.watson.ibm.com> <20141120165351.5264.61930.stgit@warthog.procyon.org.uk> <20141120165414.5264.95354.stgit@warthog.procyon.org.uk> <1416787243.9616.4.camel@dhcp-9-2-203-236.watson.ibm.com> To: Mimi Zohar Cc: dhowells@redhat.com, mmarek@suse.cz, keyrings@linux-nfs.org, d.kasatkin@samsung.com, rusty@rustcorp.com.au, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, vgoyal@redhat.com Subject: Re: [Keyrings] [PATCH 2/5] X.509: Support X.509 lookup by Issuer+Serial form AuthorityKeyIdentifier MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <536.1416848115.1@warthog.procyon.org.uk> Date: Mon, 24 Nov 2014 16:55:15 +0000 Message-ID: <537.1416848115@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mimi Zohar wrote: > Don't assume that the issuer & serialNumber are specified. Bah... I didn't assume, I just did it wrong. > +#define DEBUG 1 Shouldn't be in the patch. > + if (id) { Tab, not spaces. I'll fix these up and merge your patch into mine to avoid the issues coming out in bisection. David