All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maged Mokhtar <mmokhtar@petasan.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com, mpatocka@redhat.com
Subject: Re: dm-writecache: change config parameters using messages
Date: Thu, 7 Nov 2019 20:55:19 +0200	[thread overview]
Message-ID: <5370f009-c324-1530-4400-adf1b59f0bbd@petasan.org> (raw)
In-Reply-To: <20191106150831.GA27888@redhat.com>



On 06/11/2019 17:08, Mike Snitzer wrote:
> On Tue, Nov 05 2019 at  4:19pm -0500,
> Maged Mokhtar <mmokhtar@petasan.org> wrote:
> 
>> Gentle ping please.
>>
>> It could add flexibility in changing cache parameters after device creation.
> 
> I'm inclined to _not_ take this type of change.
> 
> Why isn't changing the config parameters via table reload viable for
> you?
> 


Hi Mike,

Thank you for your response. The main issue is to enable setting some 
config parameters while the device is mounted and running and avoid 
calling target ctr() by sending parameter changes via messages. A 
similar setup was used in dm-cache.

The reason is that tuning the write cache may require run time changes. 
If un-tuned we can observes periods of spikes and/or step like disk 
utilization on the slow device during writeback using iostat, and these 
spikes correspond to periods of increased client io latency. Utilization 
can be tuned by varying the number of active writeback jobs + the gap 
between high and low marks to achieve a smooth high utilization.  Such 
tuning is difficult to do when creating the cache device as it depends 
on the hardware and io workload. We are hoping to use some userspace 
monitoring and tuning tool to periodically adjust these values while the 
device is running.

/Maged

  reply	other threads:[~2019-11-07 18:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-22 19:39 [PATCH] dm-writecache: change config parameters using messages Maged Mokhtar
2019-11-05 21:19 ` Maged Mokhtar
2019-11-06 15:08   ` Mike Snitzer
2019-11-07 18:55     ` Maged Mokhtar [this message]
2019-11-07 19:09       ` Mike Snitzer
2019-11-07 19:29         ` Maged Mokhtar
2019-11-07 19:49           ` Mike Snitzer
2019-11-07 19:50           ` Mikulas Patocka
2019-11-07 20:16             ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5370f009-c324-1530-4400-adf1b59f0bbd@petasan.org \
    --to=mmokhtar@petasan.org \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.