From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmIIw-0000T9-3n for qemu-devel@nongnu.org; Mon, 19 May 2014 03:48:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmIIq-00078H-1J for qemu-devel@nongnu.org; Mon, 19 May 2014 03:48:14 -0400 Received: from mail-ee0-f44.google.com ([74.125.83.44]:59555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmIIp-00078C-Qt for qemu-devel@nongnu.org; Mon, 19 May 2014 03:48:07 -0400 Received: by mail-ee0-f44.google.com with SMTP id c41so3240679eek.17 for ; Mon, 19 May 2014 00:48:06 -0700 (PDT) Message-ID: <5379B732.80806@m2r.biz> Date: Mon, 19 May 2014 09:48:02 +0200 From: Fabio Fantoni MIME-Version: 1.0 References: <1400237624-8505-1-git-send-email-tiejun.chen@intel.com> <1400237624-8505-5-git-send-email-tiejun.chen@intel.com> <1400481887.32155.34.camel@nilsson.home.kraxel.org> In-Reply-To: <1400481887.32155.34.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Tiejun Chen Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, weidong.han@intel.com, mst@redhat.com, allen.m.kay@intel.com, Kelly.Zytaruk@amd.com, jean.guyader@eu.citrix.com, anthony.perard@citrix.com, anthony@codemonkey.ws, yang.z.zhang@intel.com Il 19/05/2014 08:44, Gerd Hoffmann ha scritto: > Hi, > >> + /* >> + * Some video bioses and gfx drivers will assume the bdf of IGD is 00:02.0. >> + * So user need to set it to 00:02.0 in Xen configure file explicitly, >> + * otherwise IGD will fail to work. >> + */ >> + pci_reserve_pci_devfn(b, PCI_DEVFN(2, 0)); > That is asking for trouble. Slot 2 is used by the qemu vga cards by > default, and for quite a while (before memory api was merged) it even > was impossible to change it. libvirt still places the vga card at slot > 2 for that reason -> boom. I wouldn't be surprised if you find that > assumption in other management libs / apps too. > > Why do you need that patch in the first place? It should be possible to > configure qemu to not occupy slot 2 if you need it that way. Just pass > '-vga none' to qemu. Which you probably want anyway if you pass-through > a vga to the guest. And explicitly configure a slot (via addr= > property) for all your pci devices. Doing it only for the IGD works too > if you list the device before any other pci device on the qemu command > line. > > cheers, > Gerd I already added vga none support on libxl, useful also for this cases: http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=2e5738ff47b9d2e1948024100f87b1a25fcf004a This patch is already tested and working, for now I not tested and I can't test with intel gpu passthrough, someone can test it with intel gpu passthrough? Thanks for any reply and sorry for my bad english. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Fantoni Subject: Re: [Xen-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD Date: Mon, 19 May 2014 09:48:02 +0200 Message-ID: <5379B732.80806@m2r.biz> References: <1400237624-8505-1-git-send-email-tiejun.chen@intel.com> <1400237624-8505-5-git-send-email-tiejun.chen@intel.com> <1400481887.32155.34.camel@nilsson.home.kraxel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1400481887.32155.34.camel@nilsson.home.kraxel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Gerd Hoffmann , Tiejun Chen Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, weidong.han@intel.com, mst@redhat.com, allen.m.kay@intel.com, Kelly.Zytaruk@amd.com, jean.guyader@eu.citrix.com, anthony.perard@citrix.com, anthony@codemonkey.ws, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org Il 19/05/2014 08:44, Gerd Hoffmann ha scritto: > Hi, > >> + /* >> + * Some video bioses and gfx drivers will assume the bdf of IGD is 00:02.0. >> + * So user need to set it to 00:02.0 in Xen configure file explicitly, >> + * otherwise IGD will fail to work. >> + */ >> + pci_reserve_pci_devfn(b, PCI_DEVFN(2, 0)); > That is asking for trouble. Slot 2 is used by the qemu vga cards by > default, and for quite a while (before memory api was merged) it even > was impossible to change it. libvirt still places the vga card at slot > 2 for that reason -> boom. I wouldn't be surprised if you find that > assumption in other management libs / apps too. > > Why do you need that patch in the first place? It should be possible to > configure qemu to not occupy slot 2 if you need it that way. Just pass > '-vga none' to qemu. Which you probably want anyway if you pass-through > a vga to the guest. And explicitly configure a slot (via addr= > property) for all your pci devices. Doing it only for the IGD works too > if you list the device before any other pci device on the qemu command > line. > > cheers, > Gerd I already added vga none support on libxl, useful also for this cases: http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=2e5738ff47b9d2e1948024100f87b1a25fcf004a This patch is already tested and working, for now I not tested and I can't test with intel gpu passthrough, someone can test it with intel gpu passthrough? Thanks for any reply and sorry for my bad english. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel