From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf] bpf: Use option "help" in the llvm-objcopy test
Date: Tue, 24 Jul 2018 17:30:23 -0700
Message-ID: <537c2d77-a10d-e108-e6a3-75c5c7a4b954@fb.com>
References: <20180720053410.3891870-1-kafai@fb.com>
 <34e16aab-db8b-ef38-4c56-6bbf6e81f673@iogearbox.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alexei Starovoitov <ast@fb.com>, <kernel-team@fb.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>, <netdev@vger.kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:38620 "EHLO
        mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S2388441AbeGYBj5 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 24 Jul 2018 21:39:57 -0400
In-Reply-To: <34e16aab-db8b-ef38-4c56-6bbf6e81f673@iogearbox.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 7/20/18 1:37 AM, Daniel Borkmann wrote:
> On 07/20/2018 07:34 AM, Martin KaFai Lau wrote:
>> I noticed the "--version" option of the llvm-objcopy command has recently
>> disappeared from the master llvm branch.  It is currently used as a BTF
>> support test in tools/testing/selftests/bpf/Makefile.
>>
>> This patch replaces it with "--help" which should be
>> less error prone in the future.
>>
>> Fixes: c0fa1b6c3efc ("bpf: btf: Add BTF tests")
>> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
> 
> Looks good, ran into the same recently as well from llvm git. Wondering whether
> the "--version" removal there was by accident or on purpose. In any case, applied

The option "--version" seems removed by accident.
On 6.0.0, the option handling is done by llvm.
      static cl::opt<std::string>
              OutputFormat("O", cl::desc("Set output format to one of the
                           following:"
                           "\n\tbinary"));
      cl::ParseCommandLineOptions(argc, argv, "llvm objcopy utility\n");
That is, the options are defined through llvm option handling system and
option "--version" is handled by llvm automatically.

In 7.0.0, llvm-objcopy tries to handle the options itself. 
Unfortunately, it did not define "version" option in its option file, so
"llvm-objcopy --version" won't work any more.

I will raise a bug or fix the issue properly.

> to bpf tree, thanks! If we make another change to the Makefile in near future,
> we should also make a comment there that the llvm-objcopy is used by pahole -J
> internally to make it a bit more clear in case someone is wondering why it's not
> used in the Makefile itself.
> 
> Thanks,
> Daniel
>