From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Ziswiler Subject: Re: [PATCH 2/3] arm: tegra: enable igb, stmpe, i2c chardev, spidev, lm95245, pwm leds Date: Mon, 02 Jun 2014 18:28:37 +0200 Message-ID: <538CA635.4050502@ziswiler.com> References: <39a8704a4c8170d6b0620a1e5e44042eae6d8810.1401665237.git.marcel@ziswiler.com> <538CA24B.1010602@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <538CA24B.1010602@wwwdotorg.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Warren , thierry.reding@gmail.com Cc: linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, stefan@agner.ch List-Id: linux-tegra@vger.kernel.org On 06/02/2014 06:11 PM, Stephen Warren wrote: >> BTW: How about MTD_SPI_NOR, > > That might only exist in linux-next. > >> PROC_DEVICETREE and CRYPTO_DEV_TEGRA_AES >> which I haven't found any mentioning anywhere? > > The TEGRA_AES driver has been removed, so the option should be removed > from defconfig too. I don't know what happened to PROC_DEVICTREE - it > doesn't seem to exist any more. Was it replaced by something else or > deleted? Feel free to send patches for those. OK, will do. >> diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig > >> +CONFIG_SPI_SPIDEV=y > > Is this useful with DT? I thought that unlike I2C_CHARDEV, spidev needed > dummy devices to exist in DT for spidev to work? If so, there's not much > point adding the option to defconfig, since people can add it when they > put the dummy devices into DT. Yes, the Apalis T30 DT I sent actually contains two of them which we call generic Apalis SPI1 and SPI2 out-of-the-box configured for exactly that. Without the config enabled though it probably does not make much sense to include it in the DT so I would consider removing it again. From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcel@ziswiler.com (Marcel Ziswiler) Date: Mon, 02 Jun 2014 18:28:37 +0200 Subject: [PATCH 2/3] arm: tegra: enable igb, stmpe, i2c chardev, spidev, lm95245, pwm leds In-Reply-To: <538CA24B.1010602@wwwdotorg.org> References: <39a8704a4c8170d6b0620a1e5e44042eae6d8810.1401665237.git.marcel@ziswiler.com> <538CA24B.1010602@wwwdotorg.org> Message-ID: <538CA635.4050502@ziswiler.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/02/2014 06:11 PM, Stephen Warren wrote: >> BTW: How about MTD_SPI_NOR, > > That might only exist in linux-next. > >> PROC_DEVICETREE and CRYPTO_DEV_TEGRA_AES >> which I haven't found any mentioning anywhere? > > The TEGRA_AES driver has been removed, so the option should be removed > from defconfig too. I don't know what happened to PROC_DEVICTREE - it > doesn't seem to exist any more. Was it replaced by something else or > deleted? Feel free to send patches for those. OK, will do. >> diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig > >> +CONFIG_SPI_SPIDEV=y > > Is this useful with DT? I thought that unlike I2C_CHARDEV, spidev needed > dummy devices to exist in DT for spidev to work? If so, there's not much > point adding the option to defconfig, since people can add it when they > put the dummy devices into DT. Yes, the Apalis T30 DT I sent actually contains two of them which we call generic Apalis SPI1 and SPI2 out-of-the-box configured for exactly that. Without the config enabled though it probably does not make much sense to include it in the DT so I would consider removing it again.