From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2] kvm: x86: emulate monitor and mwait instructions as nop Date: Tue, 03 Jun 2014 11:17:48 +0200 Message-ID: <538D92BC.4060203@redhat.com> References: <20140507205210.GA30030@ERROL.INI.CMU.EDU> <20140602192530.GC1653@ERROL.INI.CMU.EDU> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mst@redhat.com, afaerber@suse.de, agraf@suse.de To: "Gabriel L. Somlo" , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:3760 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbaFCJRy (ORCPT ); Tue, 3 Jun 2014 05:17:54 -0400 In-Reply-To: <20140602192530.GC1653@ERROL.INI.CMU.EDU> Sender: kvm-owner@vger.kernel.org List-ID: Il 02/06/2014 21:25, Gabriel L. Somlo ha scritto: > Would it make sense to make this a module parameter, > (e.g., "int emulate_mwait") ? > > Default would be 0 (no emulation). 1 would mean "emulate as nop", and > if anyone ever figures out how to do proper page-locking based > emulation we could use 2 to enable that, etc. ? > > Not sure we'd want qemu to enable/disable it automatically, though... > > What do you all think ? I think it's fine as it is now. :) Paolo