From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
Subject: Re: [PATCH 08/11] drm/i915: BDW PSR: Remove limitations
 that aren't valid for BDW.
Date: Tue, 03 Jun 2014 16:50:16 +0530
Message-ID: <538DAF70.3020308@intel.com>
References: <1400199190-2424-1-git-send-email-rodrigo.vivi@gmail.com>
 <1400199190-2424-9-git-send-email-rodrigo.vivi@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 0D3686E2BF
 for <intel-gfx@lists.freedesktop.org>; Tue,  3 Jun 2014 04:20:39 -0700 (PDT)
In-Reply-To: <1400199190-2424-9-git-send-email-rodrigo.vivi@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 5/16/2014 5:43 AM, Rodrigo Vivi wrote:
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> ---
>   drivers/gpu/drm/i915/intel_dp.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 28144d3..9421b0b 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1768,6 +1768,10 @@ static bool intel_edp_psr_match_conditions(struct intel_dp *intel_dp)
>   		return false;
>   	}
>
> +	/* Below limitations aren't valid for Broadwell */
> +	if (IS_BROADWELL(dev))
> +		goto out;

I couldn't figure out any sprite related restrictions for HSW as well. 
Is this because FBC logic doesn't track sprites in HSW?

Thanks,
Vijay


> +
>   	if (I915_READ(SPRCTL(intel_crtc->pipe)) & SPRITE_ENABLE) {
>   		DRM_DEBUG_KMS("PSR condition failed: Sprite is Enabled\n");
>   		return false;
> @@ -1784,6 +1788,7 @@ static bool intel_edp_psr_match_conditions(struct intel_dp *intel_dp)
>   		return false;
>   	}
>
> + out:
>   	dev_priv->psr.source_ok = true;
>   	return true;
>   }
>