From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44760)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WrrnJ-0005Dp-86
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:42:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WrrnD-0000jf-60
	for qemu-devel@nongnu.org; Tue, 03 Jun 2014 12:42:37 -0400
Message-ID: <538DFAF3.2070106@gmail.com>
Date: Tue, 03 Jun 2014 11:42:27 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1401787684-31895-1-git-send-email-aik@ozlabs.ru>
	<1401787684-31895-8-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1401787684-31895-8-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 07/29] target-ppc: Add PMC7/8 to 970
	class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>

On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
> Compared to PowerISA-compliant CPUs, 970 family has most of them plus
> PMC7/8 which are only present on 970 but not on POWER5 and later CPUs.
> 
> Since we are changing SPRs for Book3s/970 families, let's add them too.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  target-ppc/cpu.h            |  4 ++++
>  target-ppc/translate_init.c | 26 ++++++++++++++++++++++++++
>  2 files changed, 30 insertions(+)
> 

[ ... ]

> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index e4c9a4c..0fcf918 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -7442,6 +7442,30 @@ static void gen_spr_book3s_pmu_user(CPUPPCState *env)
>                   0x00000000);
>  }
>  
> +static void gen_spr_970_pmu_hypv(CPUPPCState *env)
> +{
> +    spr_register(env, SPR_970_PMC7, "PMC7",
> +                 SPR_NOACCESS, SPR_NOACCESS,
> +                 &spr_read_generic, &spr_write_generic,
> +                 0x00000000);
> +    spr_register(env, SPR_970_PMC8, "PMC8",
> +                 SPR_NOACCESS, SPR_NOACCESS,
> +                 &spr_read_generic, &spr_write_generic,
> +                 0x00000000);
> +}
> +

Sorry ... forgot my comments: Shouldn't this be named "gen_spr_970_pm_sup" ?  These are supervisor SPRs, not hypervisor SPRs.

> +static void gen_spr_970_pmu_user(CPUPPCState *env)
> +{
> +    spr_register(env, SPR_970_UPMC7, "UPMC7",
> +                 &spr_read_ureg, SPR_NOACCESS,
> +                 &spr_read_ureg, SPR_NOACCESS,
> +                 0x00000000);
> +    spr_register(env, SPR_970_UPMC8, "UPMC8",
> +                 &spr_read_ureg, SPR_NOACCESS,
> +                 &spr_read_ureg, SPR_NOACCESS,
> +                 0x00000000);
> +}
> +

Are UPMC7/8 writeable from supervisor state?  (the 970 UM is not crystal clear here).