From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbaFDMUG (ORCPT ); Wed, 4 Jun 2014 08:20:06 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:57633 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611AbaFDMUE (ORCPT ); Wed, 4 Jun 2014 08:20:04 -0400 Message-ID: <538F0EED.7030504@hitachi.com> Date: Wed, 04 Jun 2014 21:19:57 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Namhyung Kim , Ingo Molnar , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH -tip ] [BUGFIX] perf/probe: Fix perf probe to find correct variable DIE References: <20140529105232.28251.30447.stgit@ltc230.yrl.intra.hitachi.co.jp> <20140529121930.30879.87092.stgit@ltc230.yrl.intra.hitachi.co.jp> <53872A72.6040007@hitachi.com> <20140603203823.GG3696@kernel.org> <538ED7DE.5070508@hitachi.com> <20140604113124.GC5555@krava.brq.redhat.com> In-Reply-To: <20140604113124.GC5555@krava.brq.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2014/06/04 20:31), Jiri Olsa wrote: > On Wed, Jun 04, 2014 at 05:25:02PM +0900, Masami Hiramatsu wrote: >> (2014/06/04 5:38), Arnaldo Carvalho de Melo wrote: >>> Now trying to reference a bogus member name: >>> >>> [root@zoo ~]# perf probe 'vfs_getname=getname_flags:65 pathname=result->BOGUS:string' >>> result(type:filename) has no member BOGUS. >>> Failed to find 'result' in this function. >>> Error: Failed to add events. (-22) >>> [root@zoo ~]# >>> >>> No segfault, albeit it produces a bogus error message, as it clearly >>> _finds_ the 'result' variable, its just that it is of a struct type that >>> _has_ no such 'BOGUS' _member_. >> >> Right, I'll fix that. > > should I wait for new patchset, or should I take those 2? No, those 2 patches are urgently required, because one fixes SEGV critical error, and the other fixes a wrong behavior (catch up to the latest dwarf), which is also degradation. I think changing error messages is a kind of usability enhancement. Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com