From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsOnj-0001lF-2r for qemu-devel@nongnu.org; Wed, 04 Jun 2014 23:57:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsOne-0006Z9-4Q for qemu-devel@nongnu.org; Wed, 04 Jun 2014 23:57:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsOnd-0006X4-Q8 for qemu-devel@nongnu.org; Wed, 04 Jun 2014 23:57:10 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s553v85D006774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 4 Jun 2014 23:57:08 -0400 Message-ID: <538FEA8F.1090809@redhat.com> Date: Wed, 04 Jun 2014 21:57:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401939756-11150-1-git-send-email-famz@redhat.com> In-Reply-To: <1401939756-11150-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gbsfB4FrAxjqALDhkKuSIGkESIR9URTFu" Subject: Re: [Qemu-devel] [PATCH 0/3] mirror: Fix behavior for zero byte image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , jcody@redhat.com, Stefan Hajnoczi , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gbsfB4FrAxjqALDhkKuSIGkESIR9URTFu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/04/2014 09:42 PM, Fam Zheng wrote: > The current behavior of mirroring zero byte image is slightly different= from > non-zero image: the BLOCK_JOB_READY event is skipped and job is complet= ed > immediately. This is not a big problem for human user but only makes ma= nagement > software harder to write. Since we are focusing on an good API instead = of UI, > let's make the behavior more consistent and predictable. >=20 > The first patch fixes the behavior. The following two patches add test = case for > the involved code path. >=20 > Thanks for Eric Blake to report this! >=20 > Fam >=20 Thanks for a speedy fix. Series: Reviewed-by: Eric Blake >=20 > Fam Zheng (3): > mirror: Go through ready -> complete process for 0 len image > qemu-iotests: Test BLOCK_JOB_READY event for 0Kb image active commit > qemu-iotests: Test 0-length image for mirror >=20 > block/mirror.c | 11 ++++++++++- > tests/qemu-iotests/040 | 11 ++++++++++- > tests/qemu-iotests/040.out | 4 ++-- > tests/qemu-iotests/041 | 5 +++++ > tests/qemu-iotests/041.out | 4 ++-- > 5 files changed, 29 insertions(+), 6 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gbsfB4FrAxjqALDhkKuSIGkESIR9URTFu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTj+qQAAoJEKeha0olJ0NqrbsH/0xtyFPb1tLohjUSBsji5vMu kG09Xb+lyr/o3BKGbk6AcUjwh1veO4y/erYogELfw1ooK6NbgwKyOUIk2G+soucp PtMQPXu25YsZbBL2FxX+iDSBWJ/D4ViHjb87lh7qtU7aqRh2oANMnoBGLdg29+h2 xbNeHYycfZkc8OHsmx53T7XU1J1zqsMqHszDA1lKcwhHUpRJk2WvW6MuOQiW8n5m tsjCIrKmItH05BqNAtuRrY2YaA7J9VAPl2rfum1WT9IWLs9DcqbQXcki6rcRFu7Z GQywq5yLUn+ZEjnRyYzj3FTEcK7y3osLae4xG0EUDNghH4qdGrn3dXvJEenSgpo= =JFEa -----END PGP SIGNATURE----- --gbsfB4FrAxjqALDhkKuSIGkESIR9URTFu--