From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode Date: Wed, 19 Dec 2018 10:26:43 -0800 Message-ID: <538b1829-422a-bf15-b024-e0bf933c930a@gmail.com> References: <20181217204423.14271-1-sergio.paracuellos@gmail.com> <20181218151044.GA26992@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com, Andrew Lunn , vivien.didelot@savoirfairelinux.com, driverdev-devel@linuxdriverproject.org, davem@davemloft.net, netdev@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" To: Sergio Paracuellos , Rob Herring Return-path: Received: from mail-yb1-f194.google.com ([209.85.219.194]:37839 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727841AbeLSS0x (ORCPT ); Wed, 19 Dec 2018 13:26:53 -0500 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/18/18 10:23 PM, Sergio Paracuellos wrote: > Hi Rob, > > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring wrote: >> >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote: >>> Add device-tree binding example of the ksz9477 switch managed in i2c mode. >>> >>> Cc: devicetree@vger.kernel.org >>> Signed-off-by: Sergio Paracuellos >>> --- >>> Changes v3: >>> - No changes. Just resent patches together. >>> >>> Changes v2: >>> - Use generic name for label of the switch and make sure reg and @X >>> have the same value. >>> >>> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++ >>> 1 file changed, 50 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt >>> index 0f407fb371ce..d3c4b9d4f416 100644 >>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt >>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt >>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0: >>> }; >>> }; >>> }; >>> + >>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0: >>> + >>> + eth0: ethernet@10001000 { >> >> Why do we have all this indentation? Please remove. And use tab chars, >> not spaces. > > The original file format is using all of this indentation. So I think > we would need a patch to change de format of the original file and > another with this new changes properly formatted. The original formatting should be fixed, but your changes should adopt the correct style from the first time they are submitted. Do you mind resubmitting with only one tab? We can fix the original examples as a follow-up patch. Thanks! -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 55EC61BF416 for ; Wed, 19 Dec 2018 18:26:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 52C3387994 for ; Wed, 19 Dec 2018 18:26:53 +0000 (UTC) Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id McFRbo1Tey2h for ; Wed, 19 Dec 2018 18:26:52 +0000 (UTC) Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) by hemlock.osuosl.org (Postfix) with ESMTPS id 9176987941 for ; Wed, 19 Dec 2018 18:26:52 +0000 (UTC) Received: by mail-yb1-f194.google.com with SMTP id r11so8256074ybp.12 for ; Wed, 19 Dec 2018 10:26:52 -0800 (PST) Subject: Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode References: <20181217204423.14271-1-sergio.paracuellos@gmail.com> <20181218151044.GA26992@bogus> From: Florian Fainelli Message-ID: <538b1829-422a-bf15-b024-e0bf933c930a@gmail.com> Date: Wed, 19 Dec 2018 10:26:43 -0800 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Sergio Paracuellos , Rob Herring Cc: Woojung.Huh@microchip.com, Andrew Lunn , vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, driverdev-devel@linuxdriverproject.org, UNGLinuxDriver@microchip.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , davem@davemloft.net On 12/18/18 10:23 PM, Sergio Paracuellos wrote: > Hi Rob, > > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring wrote: >> >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote: >>> Add device-tree binding example of the ksz9477 switch managed in i2c mode. >>> >>> Cc: devicetree@vger.kernel.org >>> Signed-off-by: Sergio Paracuellos >>> --- >>> Changes v3: >>> - No changes. Just resent patches together. >>> >>> Changes v2: >>> - Use generic name for label of the switch and make sure reg and @X >>> have the same value. >>> >>> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++ >>> 1 file changed, 50 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt >>> index 0f407fb371ce..d3c4b9d4f416 100644 >>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt >>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt >>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0: >>> }; >>> }; >>> }; >>> + >>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0: >>> + >>> + eth0: ethernet@10001000 { >> >> Why do we have all this indentation? Please remove. And use tab chars, >> not spaces. > > The original file format is using all of this indentation. So I think > we would need a patch to change de format of the original file and > another with this new changes properly formatted. The original formatting should be fixed, but your changes should adopt the correct style from the first time they are submitted. Do you mind resubmitting with only one tab? We can fix the original examples as a follow-up patch. Thanks! -- Florian _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel