All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Beichler <Benjamin.Beichler@uni-rostock.de>
To: Johannes Berg <johannes@sipsolutions.net>,
	<linux-wireless@vger.kernel.org>
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH v2 3/4] cfg80211: reg: remove support for built-in regdb
Date: Mon, 13 Nov 2017 10:19:18 +0100	[thread overview]
Message-ID: <5392a1bb-378c-17c6-de0d-862e86041c2e@uni-rostock.de> (raw)
In-Reply-To: <20171009095018.5289-4-johannes@sipsolutions.net>

[-- Attachment #1: Type: text/plain, Size: 3053 bytes --]

Hi Johannes,

Am 09.10.2017 um 11:50 schrieb Johannes Berg:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Parsing and building C structures from a regdb is no longer needed
> since the "firmware" file (regulatory.db) can be linked into the
> kernel image to achieve the same effect.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  Documentation/networking/regulatory.txt |  22 +----
>  net/wireless/Kconfig                    |  24 +----
>  net/wireless/Makefile                   |   6 --
>  net/wireless/db.txt                     |  17 ----
>  net/wireless/genregdb.awk               | 158 --------------------------------
>  net/wireless/reg.c                      |  39 --------
>  net/wireless/regdb.h                    |  23 -----
>  7 files changed, 3 insertions(+), 286 deletions(-)
>  delete mode 100644 net/wireless/db.txt
>  delete mode 100644 net/wireless/genregdb.awk
>  delete mode 100644 net/wireless/regdb.h
>
> diff --git a/Documentation/networking/regulatory.txt b/Documentation/networking/regulatory.txt
> index 46c8d8b1cc66..381e5b23d61d 100644
> --- a/Documentation/networking/regulatory.txt
> +++ b/Documentation/networking/regulatory.txt
> @@ -200,23 +200,5 @@ Then in some part of your code after your wiphy has been registered:
>  Statically compiled regulatory database
>  ---------------------------------------
>  
> -In most situations the userland solution using CRDA as described
> -above is the preferred solution.  However in some cases a set of
> -rules built into the kernel itself may be desirable.  To account
> -for this situation, a configuration option has been provided
> -(i.e. CONFIG_CFG80211_INTERNAL_REGDB).  With this option enabled,
> -the wireless database information contained in net/wireless/db.txt is
> -used to generate a data structure encoded in net/wireless/regdb.c.
> -That option also enables code in net/wireless/reg.c which queries
> -the data in regdb.c as an alternative to using CRDA.
> -
> -The file net/wireless/db.txt should be kept up-to-date with the db.txt
> -file available in the git repository here:
> -
> -    git://git.kernel.org/pub/scm/linux/kernel/git/sforshee/wireless-regdb.git
> -
> -Again, most users in most situations should be using the CRDA package
> -provided with their distribution, and in most other situations users
> -should be building and using CRDA on their own rather than using
> -this option.  If you are not absolutely sure that you should be using
> -CONFIG_CFG80211_INTERNAL_REGDB then _DO_NOT_USE_IT_.
> +When a database should be fixed into the kernel, it can be provided as a
> +firmware file at build time that is then linked into the kernel.
>

Is there already an example regulatory.db file available? And is there
already a tool chain for creating the new format? I don't see any
corresponding commit on
https://git.kernel.org/pub/scm/linux/kernel/git/sforshee/wireless-regdb.git/
for your change. Or can I simply use the regulartory.bin as firmware file?


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5151 bytes --]

  reply	other threads:[~2017-11-13  9:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09  9:50 [PATCH v2 0/4] built-in regulatory database Johannes Berg
2017-10-09  9:50 ` [PATCH v2 1/4] cfg80211: support loading regulatory database as firmware file Johannes Berg
2017-10-09  9:50 ` [PATCH v2 2/4] cfg80211: support reloading regulatory database Johannes Berg
2017-10-09  9:50 ` [PATCH v2 3/4] cfg80211: reg: remove support for built-in regdb Johannes Berg
2017-11-13  9:19   ` Benjamin Beichler [this message]
2017-11-13  9:23     ` Johannes Berg
2017-11-13 13:36       ` Seth Forshee
2017-11-13 14:34         ` Benjamin Beichler
2017-11-13 14:36           ` Johannes Berg
     [not found]             ` <b2023534-0ea0-b3b5-f6ef-40e5dd239d38@uni-rostock.de>
     [not found]               ` <1510584253.30497.45.camel@sipsolutions.net>
2017-11-13 14:48                 ` Benjamin Beichler
2017-11-13 14:53                   ` Johannes Berg
2017-10-09  9:50 ` [PATCH v2 4/4] cfg80211: implement regdb signature checking Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5392a1bb-378c-17c6-de0d-862e86041c2e@uni-rostock.de \
    --to=benjamin.beichler@uni-rostock.de \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.