From: Antonio Quartulli <antonio@meshcoding.com>
To: "André Gaul" <gaul@web-yard.de>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] remove unnecessary logspam
Date: Mon, 09 Jun 2014 23:05:29 +0200 [thread overview]
Message-ID: <53962199.4060202@meshcoding.com> (raw)
In-Reply-To: <1402334059-28681-1-git-send-email-gaul@web-yard.de>
[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]
On 09/06/14 19:14, André Gaul wrote:
> This patch removes unnecessary logspam which resulted from superfluous
> calls to net_ratelimit(). With the supplied patch, net_ratelimit() is
> called after the loglevel has been checked.
>
> Signed-off-by: André Gaul <gaul@web-yard.de>
André,
I'd suggest you to check this patch with checkpatch.pl --strict. Here I
get many errors due to non-printable chars at the end of various lines.
Here[1] you find our guidelines (which is a set of complementary rules
to the guidelines you find in the kernel tree[2]).
Moreover, the subject must start with "batman-adv: ", because this patch
will end up in the kernel and it requires this format to easily
distinguish the subsystem that the patch is touching.
A couple of things to keep in mind while sending new versions of the
same patch:
- don't reply to an existing thread
- write [PATCHvN] (with N = version of the patch - 2 in this case) in
the subject
Cheers,
[1]
http://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patches
[2]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-06-09 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 19:53 [B.A.T.M.A.N.] [PATCH] remove unnecessary logspam André Gaul
2014-06-09 8:54 ` Antonio Quartulli
2014-06-09 17:14 ` André Gaul
2014-06-09 21:05 ` Antonio Quartulli [this message]
2014-06-09 21:36 ` André Gaul
2014-06-10 6:01 ` Antonio Quartulli
2014-06-10 15:38 ` André Gaul
2014-06-10 15:40 ` Antonio Quartulli
2014-06-10 15:45 ` André Gaul
2014-06-11 6:04 ` Antonio Quartulli
2014-06-14 1:44 ` Marek Lindner
2014-06-15 12:32 ` André Gaul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53962199.4060202@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=gaul@web-yard.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.