From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51076)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Wudv1-0003NT-Ns
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 04:30:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Wuduu-0003P8-8x
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 04:30:03 -0400
Message-ID: <53981381.6060302@suse.de>
Date: Wed, 11 Jun 2014 10:29:53 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1401869330-32449-1-git-send-email-aik@ozlabs.ru>	<1401869330-32449-2-git-send-email-aik@ozlabs.ru>	<20140610093951.6dd64ea4@redhat.com>	<20140610164107.249d8290.cornelia.huck@de.ibm.com>	<20140610104847.1cb5a424@redhat.com>	<53973277.4090500@redhat.com>
	<539749EB.2050608@suse.de>	<CAFEAcA_1HyFBnfLaeQn8oCOKpWZDV=YyUGoeAvG6Myu=_3wcqQ@mail.gmail.com>
	<1A9DA1AC-C696-452F-8D7E-68C49E339785@suse.de>
	<5397E230.8020605@redhat.com> <53980CCB.2040306@suse.de>
	<5398130D.8040706@redhat.com>
In-Reply-To: <5398130D.8040706@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Alex Bligh <alex@alex.org.uk>, Alexey Kardashevskiy <aik@ozlabs.ru>, QEMU Developers <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4r?= =?ISO-8859-1?Q?ber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>


On 11.06.14 10:27, Paolo Bonzini wrote:
> Il 11/06/2014 10:01, Alexander Graf ha scritto:
>>> Personally, I don't see anything wrong in these patches, apart from
>>> the typo that Cornelia pointed out.
>>
>> If you wanted to inject an NMI on non-sPAPR machines, such as -M mac99
>> or -M g3beige you would have to trigger an interrupt with the MPIC, not
>> the CPU itself.
>
> But right now inject-nmi was a CPU-specific interface and whoever 
> needs something different will have to find a way.
>
> You could argue that Alexey does need something different thanks to 
> his need to inject the NMI on all CPUs.
>
> What about an NMIMonitorHandler interface that takes a Monitor*, and 
> then you iterate on all of /machine looking for implementors of the 
> interface?  Then -M mac99 can add it to the MPIC, -M spapr can just 
> ignore the Monitor*, and i386/s390 can look at the current CPU.

I think modeling a button is easier and closer to what you'd actually 
get on real hardware.


Alex