From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuviW-0002mS-It for qemu-devel@nongnu.org; Wed, 11 Jun 2014 23:30:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuviP-00047n-OI for qemu-devel@nongnu.org; Wed, 11 Jun 2014 23:30:20 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:49061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuviP-00047b-JI for qemu-devel@nongnu.org; Wed, 11 Jun 2014 23:30:13 -0400 Received: by mail-pa0-f51.google.com with SMTP id ey11so517316pad.10 for ; Wed, 11 Jun 2014 20:30:12 -0700 (PDT) Message-ID: <53991EB5.6010104@ozlabs.ru> Date: Thu, 12 Jun 2014 13:29:57 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1402506183-29736-1-git-send-email-aik@ozlabs.ru> <1402506183-29736-2-git-send-email-aik@ozlabs.ru> <53989009.1000300@redhat.com> <5398EFF6.7060603@ozlabs.ru> <5399067B.20009@redhat.com> In-Reply-To: <5399067B.20009@redhat.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 1/4] cpus: Define callback for QEMU "nmi" command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Peter Maydell , Alex Bligh , Markus Armbruster , Luiz Capitulino , Alexander Graf , qemu-ppc@nongnu.org, Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Richard Henderson On 06/12/2014 11:46 AM, Eric Blake wrote: > On 06/11/2014 06:10 PM, Alexey Kardashevskiy wrote: > >>>> + * This program is free software; you can redistribute it and/or modify >>>> + * it under the terms of the GNU General Public License as published by >>>> + * the Free Software Foundation; either version 2 of the License, >>>> + * or (at your option) any later version. > >>> >>> For the GPL license to work, there has to be a Copyright line. >> >> Hm. Ok. include/hw/fw-path-provider.h (where I copied this from) does not >> have one and it was ok. > > Just because there's existing bad practice in the code base doesn't mean > new files should perpetuate it :) Paolo did that in the first place and if he does it, I assume this is at least not "bad" ;) Like this? I do not know what should be there, corporation or something or just me? --- a/hw/core/nmi.c +++ b/hw/core/nmi.c @@ -1,6 +1,8 @@ /* * NMI monitor handler class and helpers. * + * Copyright (c) 2014 Alexey Kardashevskiy + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, -- Alexey