From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41889)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WuzqB-0005Ng-Hz
	for qemu-devel@nongnu.org; Thu, 12 Jun 2014 03:54:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wuzq1-0005XJ-S6
	for qemu-devel@nongnu.org; Thu, 12 Jun 2014 03:54:31 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <539959F9.8040602@redhat.com>
Date: Thu, 12 Jun 2014 09:42:49 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402506183-29736-1-git-send-email-aik@ozlabs.ru>	<1402506183-29736-3-git-send-email-aik@ozlabs.ru>	<53989212.6060603@redhat.com>
	<5398EF94.5050407@ozlabs.ru>
In-Reply-To: <5398EF94.5050407@ozlabs.ru>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI
	interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@redhat.com>, Alexander Graf <agraf@suse.de>, Markus Armbruster <armbru@redhat.com>, qemu-ppc@nongnu.org, Alex Bligh <alex@alex.org.uk>, Cornelia Huck <cornelia.huck@de.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, Richard Henderson <rth@twiddle.net>

Il 12/06/2014 02:08, Alexey Kardashevskiy ha scritto:
>> > I would use the /machine object itself, not an extra object.  Otherwise
>> > this looks good.
>
> "/machine" object is "machine" parameter from s390_init()? How do I add an
> interface to it? Create a machine class as it is done by
> spapr_machine_info? I am not that familiar with QOM and definitely miss
> something.

No, you are not. :)  You need exactly to do what was done for sPAPR. 
Note that s390 has two machine classes.

Paolo