From mboxrd@z Thu Jan 1 00:00:00 1970 From: "S, Deepak" Subject: Re: [PATCH] drm/i915/vlv: drop punit freq staus read after setting idle Date: Fri, 13 Jun 2014 00:11:47 +0530 Message-ID: <5399F46B.2090302@intel.com> References: <1402001374-2657-1-git-send-email-jbarnes@virtuousgeek.org> <20140606082924.GD27580@intel.com> <20140606080320.20fcd778@jbarnes-desktop> <20140611165611.GM27580@intel.com> <53991407.1090402@intel.com> <5399EE27.4020701@intel.com> <20140612184032.GW27580@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D9AA6E963 for ; Thu, 12 Jun 2014 11:41:52 -0700 (PDT) In-Reply-To: <20140612184032.GW27580@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?ISO-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 6/13/2014 12:10 AM, Ville Syrj=E4l=E4 wrote: > On Thu, Jun 12, 2014 at 11:45:03PM +0530, S, Deepak wrote: >> >> I was polling VLV_GTLC_SURVIVABILITY_REG and VLV_GTLC_PW_STATUS to = make >> >> sure both render and media wells and the gfx clock remain off, and I >> >> was also monitoring vnn via svid. While that was going on I just re= wrote >> >> PUNIT_REG_GPU_FREQ_REQ to make Punit change the frequency, and sure >> >> enough it did, and svid showed me that vnn had also changed. So it >> >> appears there's no need to have the gfx clock on to change its freq= uency >> >> on this BYT. >> >> >> >> I wonder if this part of the workaround was only needed on older pa= rts. >> >> Deepak, any ideas? >> > >> > Yes ville, this was added initial for older parts and force gfx clock >> > was part of the workaround. >> > We have not verified this on newer parts. Let me check with hw guys = to >> > see if workaround still exits and when this was fixed. >> >> Hi Ville, Got the confirmation from HW team, this WA as been fixed in >> latest stepping, > > What's latest here? Did we ever ship any of the steppings that still > need the gfx clock force? > >> we can remove the force gfx clock, mask and request >> only the min freq when we are idle. >> >> You will submit patch will fix or you want me to do it? > > Go ahead if you have time. I'm already juggling too many things :) Ok. I will send the patch for review :)