From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v5 06/21] xen/arm: segregate and split GIC
	low level functionality
Date: Thu, 12 Jun 2014 23:46:23 +0100
Message-ID: <539A2DBF.7060601@linaro.org>
References: <1402580192-13937-1-git-send-email-vijay.kilari@gmail.com>
	<1402580192-13937-7-git-send-email-vijay.kilari@gmail.com>
	<alpine.DEB.2.02.1406121719420.13771@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1406121719420.13771@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, vijay.kilari@gmail.com
Cc: Ian.Campbell@citrix.com, Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org



On 12/06/14 17:26, Stefano Stabellini wrote:
> That's better: same locking as before.
> At this point you should keep the:
>
> ASSERT(spin_is_locked(&desc->lock));

+1 this assert is very handy in debug mode to know if the caller 
correctly take the desc lock.

Regards,

-- 
Julien Grall