From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvX6k-0000lW-8r for qemu-devel@nongnu.org; Fri, 13 Jun 2014 15:25:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvX6g-00084B-1O for qemu-devel@nongnu.org; Fri, 13 Jun 2014 15:25:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvX6f-000843-Lc for qemu-devel@nongnu.org; Fri, 13 Jun 2014 15:25:45 -0400 Message-ID: <539B5035.80909@redhat.com> Date: Fri, 13 Jun 2014 13:25:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com> <1401970944-18735-8-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1401970944-18735-8-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MKIGb0qnIghir6objhnohHFhxfinDBJv0" Subject: Re: [Qemu-devel] [PATCH V6 07/29] qapi: add new schema file qapi-event.json List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, Max Reitz , armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MKIGb0qnIghir6objhnohHFhxfinDBJv0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/05/2014 06:22 AM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > Makefile | 12 ++++++++---- > qapi-schema.json | 2 ++ > 2 files changed, 10 insertions(+), 4 deletions(-) > create mode 100644 qapi-event.json >=20 > diff --git a/Makefile b/Makefile > index 237657e..554fb2d 100644 > --- a/Makefile > +++ b/Makefile > @@ -247,22 +247,26 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scri= pts/qapi-commands.py $(qapi-py) > " GEN $@") > =20 > qapi-types.c qapi-types.h :\ > -$(SRC_PATH)/qapi-schema.json $(SRC_PATH)/scripts/qapi-types.py $(qapi-= py) > +$(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi-event.json \ > +$(SRC_PATH)/scripts/qapi-types.py $(qapi-py) Please rebase this on top of Max's fix to add $(qapi-modules): https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01838.html > diff --git a/qapi-event.json b/qapi-event.json > new file mode 100644 > index 0000000..e69de29 Probably better to name this file qapi/event.json, to go alongside the other sub-files we have already created. > diff --git a/qapi-schema.json b/qapi-schema.json > index 115d8d0..d04514a 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -4798,3 +4798,5 @@ > ## > { 'enum': 'BlockErrorAction', > 'data': [ 'ignore', 'report', 'stop' ] } > + > +{ 'include': 'qapi-event.json' } Rather than putting this at the bottom of the file, would it make sense to put it at the top next to the other 'include' directives? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MKIGb0qnIghir6objhnohHFhxfinDBJv0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTm1A1AAoJEKeha0olJ0NqmdgH/R/N/T8Mqje7E8txia0tQGvk sAS0vmexfhjhRZJc2SolBwQ+cnCPEbDaSzkA8ZZR0haIbA373zni/SOxL81GbsWe IBi8SJiACjn7yum6XaIWyTRac49hcRbzY3o8f9BwO/WwG/nWWw11kqxs0LK/I22C 6uDBqrh2EWNI2ZbHALMMw3Q244YO+ZGk9hqMbyK5LxzNKae9GOARIXfxMfyRFoJQ ZgMS2dMp5mgUqWI4RDD79u5esW1JGvzDendOdqyUmqOYcJRCoCUwjIYafcXHOZhL 1orv073IrrjdLHHVDDsfI6TX3hLzhhGbiWzmjIXKMY6DtSpJ4bB9SGQXVp59ff4= =4w2I -----END PGP SIGNATURE----- --MKIGb0qnIghir6objhnohHFhxfinDBJv0--