From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvXQH-0006g2-4W for qemu-devel@nongnu.org; Fri, 13 Jun 2014 15:46:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvXQA-0006pD-My for qemu-devel@nongnu.org; Fri, 13 Jun 2014 15:46:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvXQA-0006oO-DK for qemu-devel@nongnu.org; Fri, 13 Jun 2014 15:45:54 -0400 Message-ID: <539B54EE.6030509@redhat.com> Date: Fri, 13 Jun 2014 13:45:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com> <1401970944-18735-8-git-send-email-wenchaoqemu@gmail.com> <539B5035.80909@redhat.com> In-Reply-To: <539B5035.80909@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o6lbPoEU7MQeD2kECPQ5bgNBj2inhNoKh" Subject: Re: [Qemu-devel] [PATCH V6 07/29] qapi: add new schema file qapi-event.json List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: armbru@redhat.com, lcapitulino@redhat.com, mdroth@linux.vnet.ibm.com, Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --o6lbPoEU7MQeD2kECPQ5bgNBj2inhNoKh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/13/2014 01:25 PM, Eric Blake wrote: > On 06/05/2014 06:22 AM, Wenchao Xia wrote: >> Signed-off-by: Wenchao Xia >> --- >> Makefile | 12 ++++++++---- >> qapi-schema.json | 2 ++ >> 2 files changed, 10 insertions(+), 4 deletions(-) >> create mode 100644 qapi-event.json >> >> diff --git a/qapi-event.json b/qapi-event.json >> new file mode 100644 >> index 0000000..e69de29 >=20 > Probably better to name this file qapi/event.json, to go alongside the > other sub-files we have already created. Also, I forgot to mention - adding an empty file to qemu.git is unusual. When you respin, make the file non-empty by at least giving it a decent comment at the top stating the purpose of the file. You could even add in a copyright/license comment, if we had any agreement on what to use (but that's already a different thread, since I already pointed out on Benoit's work to split out several .json files that we don't have any example to choose from). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --o6lbPoEU7MQeD2kECPQ5bgNBj2inhNoKh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTm1TuAAoJEKeha0olJ0NqwYIH/jLTjllGouoT8kJ8cQnRGQIV QLV+T1B3DtrvXdUvOZ9KXZutlM1h0TvnKh7s6MgMdwh3cu53KjlSuvkDgcxD6C91 LJvRhjNOArZCd6U4FY4QxJbPY1IOrJbvHHd/czbENnESwTGWNFXgaV/XYSEg1xiV ukfyewlLocx4YYp9T5ueyI7JdfgntSlziOQUSk1O9FfaPGWwt9cPRB/TfvfAscBh uctXoAS844ACkExJKY4kYFPC8tKn9JdtuAfPBPoVrSEAeWCxeuW2Ecg+KE3CYtCX SAA4VD4vrS0eoOz4je3InjD/zK2UXJTxfbOrQbvmYO/lY5BhzTgSWZhl16VfXXE= =TwSu -----END PGP SIGNATURE----- --o6lbPoEU7MQeD2kECPQ5bgNBj2inhNoKh--