From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 06/21] xen/arm: segregate and split GIC low level functionality Date: Sun, 15 Jun 2014 18:47:19 +0100 Message-ID: <539DDC27.9070804@linaro.org> References: <1402580192-13937-1-git-send-email-vijay.kilari@gmail.com> <1402580192-13937-7-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1402580192-13937-7-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org Hi Vijay, On 12/06/14 14:36, vijay.kilari@gmail.com wrote: > /* > - * - needs to be called with a valid cpu_mask, ie each cpu in the mask has > + * needs to be called with a valid cpu_mask, ie each cpu in the mask has > * already called gic_cpu_init > * - desc.lock must be held > * - arch.type must be valid (i.e != DT_IRQ_TYPE_INVALID) > @@ -231,37 +103,7 @@ static void gic_set_irq_properties(struct irq_desc *desc, > const cpumask_t *cpu_mask, > unsigned int priority) > { [..] > - ASSERT(type != DT_IRQ_TYPE_INVALID); > - ASSERT(spin_is_locked(&desc->lock)); Why did you drop these 2 ASSERTS? They should stay to help developer debugging wrong code... Hence, it validates the assertion in the comments (see above). Regards, -- Julien Grall