From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754752AbaFPIzH (ORCPT ); Mon, 16 Jun 2014 04:55:07 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:54268 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754285AbaFPIzF (ORCPT ); Mon, 16 Jun 2014 04:55:05 -0400 Message-ID: <539EB0E2.1080307@collabora.co.uk> Date: Mon, 16 Jun 2014 10:54:58 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Lee Jones CC: Samuel Ortiz , Mark Brown , Mike Turquette , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Sjoerd Simons , Daniel Stone , Tomeu Vizoso , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] clk: Add driver for Maxim 77802 PMIC clocks References: <1402306670-17041-1-git-send-email-javier.martinez@collabora.co.uk> <1402306670-17041-4-git-send-email-javier.martinez@collabora.co.uk> <20140616084427.GG14323@lee--X1> In-Reply-To: <20140616084427.GG14323@lee--X1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Lee, On 06/16/2014 10:44 AM, Lee Jones wrote: >> The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with >> Low Jitter Mode. This patch adds support for these two clocks. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> .../devicetree/bindings/clock/maxim,max77802.txt | 40 ++++ >> drivers/clk/Kconfig | 6 + >> drivers/clk/Makefile | 1 + >> drivers/clk/clk-max77802.c | 253 +++++++++++++++++++++ >> drivers/mfd/max77802.c | 3 + >> include/dt-bindings/clock/maxim,max77802.h | 22 ++ >> 6 files changed, 325 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt >> create mode 100644 drivers/clk/clk-max77802.c >> create mode 100644 include/dt-bindings/clock/maxim,max77802.h > > [...] > >> diff --git a/drivers/mfd/max77802.c b/drivers/mfd/max77802.c >> index 59696dd..33e8023 100644 >> --- a/drivers/mfd/max77802.c >> +++ b/drivers/mfd/max77802.c >> @@ -35,6 +35,9 @@ >> >> static const struct mfd_cell max77802_devs[] = { >> { .name = "max77802-pmic", }, >> +#if defined(CONFIG_COMMON_CLK_MAX77802) > > No, don't do that. If COMMON_CLK_MAX77802 is not defined it just > won't be matched, which is enough to ensure it won't be probed. > Thanks a lot for the explanation. I'll send a v2 patch-set soon which has changes based on the feedback from Mark and Krzysztof. I'll take this point into account as well. >> + { .name = "max77802-clk", }, >> +#endif >> }; > > [...] > Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) Date: Mon, 16 Jun 2014 10:54:58 +0200 Subject: [PATCH 3/5] clk: Add driver for Maxim 77802 PMIC clocks In-Reply-To: <20140616084427.GG14323@lee--X1> References: <1402306670-17041-1-git-send-email-javier.martinez@collabora.co.uk> <1402306670-17041-4-git-send-email-javier.martinez@collabora.co.uk> <20140616084427.GG14323@lee--X1> Message-ID: <539EB0E2.1080307@collabora.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Lee, On 06/16/2014 10:44 AM, Lee Jones wrote: >> The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with >> Low Jitter Mode. This patch adds support for these two clocks. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> .../devicetree/bindings/clock/maxim,max77802.txt | 40 ++++ >> drivers/clk/Kconfig | 6 + >> drivers/clk/Makefile | 1 + >> drivers/clk/clk-max77802.c | 253 +++++++++++++++++++++ >> drivers/mfd/max77802.c | 3 + >> include/dt-bindings/clock/maxim,max77802.h | 22 ++ >> 6 files changed, 325 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt >> create mode 100644 drivers/clk/clk-max77802.c >> create mode 100644 include/dt-bindings/clock/maxim,max77802.h > > [...] > >> diff --git a/drivers/mfd/max77802.c b/drivers/mfd/max77802.c >> index 59696dd..33e8023 100644 >> --- a/drivers/mfd/max77802.c >> +++ b/drivers/mfd/max77802.c >> @@ -35,6 +35,9 @@ >> >> static const struct mfd_cell max77802_devs[] = { >> { .name = "max77802-pmic", }, >> +#if defined(CONFIG_COMMON_CLK_MAX77802) > > No, don't do that. If COMMON_CLK_MAX77802 is not defined it just > won't be matched, which is enough to ensure it won't be probed. > Thanks a lot for the explanation. I'll send a v2 patch-set soon which has changes based on the feedback from Mark and Krzysztof. I'll take this point into account as well. >> + { .name = "max77802-clk", }, >> +#endif >> }; > > [...] > Best regards, Javier