From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Mon, 16 Jun 2014 13:51:16 -0600
Subject: [U-Boot] [PATCH] env_fat: use get_device_and_partition() during
 env save and load
In-Reply-To: <1402906493-26723-1-git-send-email-josh.wu@atmel.com>
References: <1402906493-26723-1-git-send-email-josh.wu@atmel.com>
Message-ID: <539F4AB4.3000108@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 06/16/2014 02:14 AM, Josh Wu wrote:
> Use get_device_and_partition() is better since:
> 1. It will call the device initialize function internally. So we can
> remove the mmc intialization code to save many lines.
> 2. It is used by fatls/fatload/fatwrite. So saveenv & load env should
> use it too.
> 3. It can parse the "D:P", "D", "D:", "D:auto" string to get correct
> device and partition information by run-time.
> 
> Also we remove the FAT_ENV_DEVICE and FAT_ENV_PART. We use a string:
> FAT_ENV_DEVICE_AND_PART.
> For at91sam9m10g45ek, it is "0". That means use device 0 and if:
> a)device 0 has no partition table, use the whole device as a FAT file
> system.
> b)device 0 has partittion table, use the partition #1.
> 
> Refer to the commit: 10a37fd7a4 for details of device & partition string.

(briefly)
Reviewed-by: Stephen Warren <swarren@nvidia.com>

Questions though:

* Can we delete the implementation of fat_register_device() now it's not
used? If it is used, shouldn't the other uses be converted in a similar
fashion?

* Should the new config variable FAT_ENV_DEVICE_AND_PART be documented
in README?