Re: [Qemu-devel] [PATCH V6 22/29] qapi event: convert other BLOCK_JOB events

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]

On 06/05/2014 06:22 AM, Wenchao Xia wrote:
> Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are
> related, converts them in one patch. The block_job_event_* functions

s/converts/convert/

> are used to keep encapsulation of BlockJob structure.
> 
> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
> ---
>  block/mirror.c           |    2 +-
>  blockdev.c               |   12 +++----
>  blockjob.c               |   36 +++++++++++++----------
>  docs/qmp/qmp-events.txt  |   71 ----------------------------------------------
>  include/block/blockjob.h |   17 ++++++++--
>  qapi-event.json          |   71 ++++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 110 insertions(+), 99 deletions(-)
> 

> -- "device":   Device name (json-string)
> -- "len":      Maximum progress value (json-int)
> -- "offset":   Current progress value (json-int)
> -              On success this is equal to len.
> -              On failure this is less than len.
> -- "speed":    Rate limit, bytes per second (json-int)
> -- "error":    Error message (json-string, optional)
> -              Only present on failure.  This field contains a human-readable
> -              error message.  There are no semantics other than that streaming
> -              has failed and clients should not try to interpret the error

This sort of disclaimer is what I'm looking for in 21/29.

>  /**
> - * qobject_from_block_job:
> + * block_job_event_cancle:

s/cancle/cancelled/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]