From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754184AbaFQCCT (ORCPT ); Mon, 16 Jun 2014 22:02:19 -0400 Received: from mail.active-venture.com ([67.228.131.205]:49341 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754001AbaFQCCS (ORCPT ); Mon, 16 Jun 2014 22:02:18 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <539FA1A1.6030502@roeck-us.net> Date: Mon, 16 Jun 2014 19:02:09 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: David Rientjes CC: Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Vincent Guittot Subject: Re: [PATCH] powerpc: Fix build warning References: <1402677499-28289-1-git-send-email-linux@roeck-us.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2014 06:25 PM, David Rientjes wrote: > On Fri, 13 Jun 2014, Guenter Roeck wrote: > >> If compiled with W=1, the following warning is seen in powerpc builds. >> >> arch/powerpc/kernel/smp.c:750:18: warning: >> type qualifiers ignored on function return type >> static const int powerpc_smt_flags(void) >> ^ >> >> This is caused by a function returning 'const int', which doesn't >> make sense to gcc. Drop 'const' to fix the problem. >> >> Reported-by: Vincent Guittot >> Signed-off-by: Guenter Roeck > > Acked-by: David Rientjes > > Although it's strange you report this happening on line 750 in the > changelog but the patch shows it differently. > In the latest kernel (v3.16-rc1) the function is at line 750. It appears that I ran the build test on a later version than the one I used to write the patch. Hope that is not a problem. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.active-venture.com (mail.active-venture.com [67.228.131.205]) by lists.ozlabs.org (Postfix) with ESMTP id 19E3F1A0350 for ; Tue, 17 Jun 2014 12:02:19 +1000 (EST) Message-ID: <539FA1A1.6030502@roeck-us.net> Date: Mon, 16 Jun 2014 19:02:09 -0700 From: Guenter Roeck MIME-Version: 1.0 To: David Rientjes Subject: Re: [PATCH] powerpc: Fix build warning References: <1402677499-28289-1-git-send-email-linux@roeck-us.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Vincent Guittot , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/16/2014 06:25 PM, David Rientjes wrote: > On Fri, 13 Jun 2014, Guenter Roeck wrote: > >> If compiled with W=1, the following warning is seen in powerpc builds. >> >> arch/powerpc/kernel/smp.c:750:18: warning: >> type qualifiers ignored on function return type >> static const int powerpc_smt_flags(void) >> ^ >> >> This is caused by a function returning 'const int', which doesn't >> make sense to gcc. Drop 'const' to fix the problem. >> >> Reported-by: Vincent Guittot >> Signed-off-by: Guenter Roeck > > Acked-by: David Rientjes > > Although it's strange you report this happening on line 750 in the > changelog but the patch shows it differently. > In the latest kernel (v3.16-rc1) the function is at line 750. It appears that I ran the build test on a later version than the one I used to write the patch. Hope that is not a problem. Guenter