From: "Jan Beulich" <jbeulich@suse.com>
To: kevin.tian@intel.com, songtaox.liu@intel.com, tim@xen.org
Cc: keir@xen.org, eddie.dong@intel.com, jun.nakajima@intel.com,
xen-devel@lists.xenproject.org, yang.z.zhang@intel.com,
robert.hu@intel.com, longtaox.pang@intel.com
Subject: Re: [PATCH] x86/EPT: flush cache when (potentially) limiting cachability
Date: Wed, 18 Jun 2014 11:02:53 +0100 [thread overview]
Message-ID: <53A171DD02000078000B6968@mail.emea.novell.com> (raw)
In-Reply-To: <582FB90AB890394081254B69739046FC0EAD97DB@SHSMSX101.ccr.corp.intel.com>
>>> "Liu, SongtaoX" <songtaox.liu@intel.com> 06/18/14 5:11 AM >>>
>> >>> On 17.06.14 at 10:33, <songtaox.liu@intel.com> wrote:
>> > Full L0 serial log as attached, it was from L0 boot to L2 guest creation.
>> > After creating L2, it takes nearly 15 minutes to print the last line of "
>> > (XEN) chg[040000] d1 [hvm_set_guest_pat+0xad/0xb9]".
>> > No other logs printed out in 20 minutes.
>>
>> So then I suppose the problem are the two hvm_set_guest_pat() invocations
>> from vvmx.c. Thinking about it, the call from that function to
>> memory_type_changed() seems unnecessary - PAT_CR contents don't
>> influence the decision taken by epte_get_entry_emt(). Tim, Kevin, you had
>> looked at the original patch - would you agree?
>> Songtao - mind giving removal of that call a try to at least verify the theory?
>
>I guess your meaning is to remove flush_all(FLUSH_CACHE) in function memory_type_changed.
No, I clearly told you to try removing the call of memory_type_changed() from
hvm_set_guest_pat(). What you did is definitely wrong.
Jan
prev parent reply other threads:[~2014-06-18 10:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 12:13 [PATCH] x86/EPT: flush cache when (potentially) limiting cachability Jan Beulich
2014-05-01 13:39 ` Tim Deegan
2014-05-30 2:07 ` Liu, SongtaoX
2014-05-30 6:26 ` Jan Beulich
2014-05-30 7:02 ` Jan Beulich
2014-05-30 7:34 ` Liu, SongtaoX
2014-05-30 11:20 ` Jan Beulich
2014-06-12 1:28 ` Liu, SongtaoX
2014-06-12 8:43 ` Ian Campbell
2014-06-16 13:01 ` Jan Beulich
2014-06-17 2:19 ` Liu, SongtaoX
2014-06-17 7:11 ` Jan Beulich
2014-06-17 8:33 ` Liu, SongtaoX
2014-06-17 15:34 ` Jan Beulich
2014-06-18 3:09 ` Liu, SongtaoX
2014-06-18 10:02 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A171DD02000078000B6968@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=longtaox.pang@intel.com \
--cc=robert.hu@intel.com \
--cc=songtaox.liu@intel.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.