From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v7 RFC 1/2] libxl: Introduce functions to
 add and remove USB devices to an HVM guest
Date: Wed, 18 Jun 2014 14:58:12 +0100
Message-ID: <53A19AF4.1040502@eu.citrix.com>
References: <1401716658-22393-1-git-send-email-george.dunlap@eu.citrix.com>		
	<1401716658-22393-2-git-send-email-george.dunlap@eu.citrix.com>	
	<1403096886.32540.22.camel@kazak.uk.xensource.com>	
	<53A19284.5070505@eu.citrix.com>
	<1403099364.6568.22.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1403099364.6568.22.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xen.org, sstanisi@cbnco.com, Fabio Fantoni <fabio.fantoni@m2r.biz>, Anthony Perard <anthony.perard@citrix.com>, Ian Jackson <ian.jackson@citrix.com>, "Simon
	(Bo) Cao" <caobosimon@gmail.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 06/18/2014 02:49 PM, Ian Campbell wrote:
>>>> +        ("backend_domid",    libxl_domid),
>>>> +        ("backend_domname",  string),
>>>> +        ("u", KeyedUnion(None, libxl_device_usb_type, "type",
>>>> +                         [("hostdev", Struct(None, [
>>>> +                                ("hostbus",   integer),
>>>> +                                ("hostaddr",  integer) ]))
>>> No need to express the host topology I think (because you can build that
>>> from the bus,addr tuples)?
>> I don't really follow.  You mean, we can drop 'host' from the last two
>> elements, and just call them "bus" and "addr"?
> Gah, I started writing one thing and then reunderstood usb and wrote
> half another.
>
> What I was trying to say is that you don't need hostaddr to describe the
> full USB topology path to the device because the (bus,addr) tuple you've
> given already does so (because each hub effectively creates a new bus
> number, so they all look like toplevel buses in this representation).

You seem to be saying that something is redundant, or that there's extra 
information somewhere; but as there are only two bits of data (bus and 
addr), and agree that I need both, I'm having a hard time telling what 
you think is redundant / could be removed..

"hostdev" is an element of the union; so the structure should unpack 
like this:
struct {
   libxl_domid backend_domid;
   char * backend_domname;
   libxl_usb_device_type type;
   union u {
    struct {
     int hostbus, hostaddr;
    } hostdev;
   };
};

At the moment, "type" can only be "hostdev"; but I'm envisioning in the 
future that "type" might be "tablet", "mouse", "keyboard", maybe 
"mass-storage", and that the union would have more elements.

Does that clear things up?  Or am I totally confused? :-)

  -George