From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Ceresoli <luca@lucaceresoli.net>
Date: Wed, 18 Jun 2014 17:32:35 +0200
Subject: [Buildroot] [PATCH 4/5] legal-info: rename
 legal-warning-pkg-savednothing helper
In-Reply-To: <4ea524430e932e989a86440588d9cf5122aa03ce.1402758331.git.yann.morin.1998@free.fr>
References: <cover.1402758331.git.yann.morin.1998@free.fr>
 <4ea524430e932e989a86440588d9cf5122aa03ce.1402758331.git.yann.morin.1998@free.fr>
Message-ID: <53A1B113.5060106@lucaceresoli.net>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Dear Yann,

Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> This helper was called when none of the sources or license
> files were saved.
>
> Now we handle license files separately from the sources,
> this is no longer the case: they are only called when the
> sources are not saved.
>
> Rename the handler and change the warning message accordingly.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>   package/pkg-generic.mk | 4 ++--
>   package/pkg-utils.mk   | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index d16908a..8a32f9d 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -640,10 +640,10 @@ endif # license files
>
>   ifeq ($$($(2)_SITE_METHOD),local)
>   # Packages without a tarball: don't save and warn
> -	@$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),local)
> +	@$(call legal-license-nosource,$$($(2)_RAWNAME),local)
>
>   else ifneq ($$($(2)_OVERRIDE_SRCDIR),)
> -	@$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),override)
> +	@$(call legal-license-nosource,$$($(2)_RAWNAME),override)
>
>   else
>   # Other packages
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index 163ef8a..471f3ed 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -101,8 +101,8 @@ define legal-warning-pkg # pkg, text
>   	echo "WARNING: $(1): $(2)" >>$(LEGAL_WARNINGS)
>   endef
>
> -define legal-warning-pkg-savednothing # pkg, {local|override}
> -	$(call legal-warning-pkg,$(1),sources and license files not saved ($(2) packages not handled))
> +define legal-license-nosource # pkg, {local|override}

I'm OK with the idea, but I not with the name.
Why "license"? This has to do with the source tarball.
Also, I would keep "warning" in the name, as it's what it is.

So, I'd rename it to legal-warning-nosource.

-- 
Luca