From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIP9-0004jG-DU for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:08:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxIP1-0001dd-VV for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:08:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIP1-0001dE-Ny for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:07:59 -0400 Message-ID: <53A1B959.5070905@redhat.com> Date: Wed, 18 Jun 2014 18:07:53 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403098014-1522-1-git-send-email-pbonzini@redhat.com> <53A1B478.8010008@redhat.com> <53A1B6CC.5020607@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 00/14] SCSI changes for 2014-06-18 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ronnie sahlberg Cc: Peter Maydell , QEMU Developers Il 18/06/2014 18:06, ronnie sahlberg ha scritto: >> > This is a very old release. I'll apply Peter's patch to disable libiscsi >> > for pre-1.9.0 versions and respin the pull request. >> > >> > I didn't want to do that because 1.4.0->1.9.0 breaks ABI, but Peter thinks >> > that versions before 1.8.0 are not reliable anyway. > +1 > > Versions prior are good for causal use but Peter is the authority on > production use here. > I think qemu should have a configure check and just force disable > iscsi support if libiscsi < 1.9.0 But you should stop breaking the ABI, coz you make it more complicated for distros to upgrade your library! :) Paolo