From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxTk7-0000cc-5y for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxTk2-0000hx-8b for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:14:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxTk1-0000hd-V7 for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:14:26 -0400 Message-ID: <53A2639F.8020105@redhat.com> Date: Wed, 18 Jun 2014 22:14:23 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com> <1403073840-32603-30-git-send-email-pbonzini@redhat.com> In-Reply-To: <1403073840-32603-30-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oPjontER8dmrwkTB8jwbrn1T5kRF0VWvx" Subject: Re: [Qemu-devel] [PATCH 2.1 29/36] qapi event: convert QUORUM events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: wenchaoqemu@gmail.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oPjontER8dmrwkTB8jwbrn1T5kRF0VWvx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/18/2014 12:43 AM, Paolo Bonzini wrote: > From: Wenchao Xia >=20 > Signed-off-by: Wenchao Xia > Signed-off-by: Paolo Bonzini > --- > +++ b/monitor.c > @@ -617,6 +617,9 @@ static void monitor_qapi_event_init(void) > monitor_qapi_event_throttle(QAPI_EVENT_RTC_CHANGE, 1000); > monitor_qapi_event_throttle(QAPI_EVENT_WATCHDOG, 1000); > monitor_qapi_event_throttle(QAPI_EVENT_BALLOON_CHANGE, 1000); > + /* limit the rate of quorum events to avoid hammering the manageme= nt */ > + monitor_qapi_event_throttle(QAPI_EVENT_QUORUM_REPORT_BAD, 1000); You could drop this comment; the one several lines earlier states pretty much the same thing. But saving it for a followup is okay with me. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oPjontER8dmrwkTB8jwbrn1T5kRF0VWvx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTomOfAAoJEKeha0olJ0NqMnoIAIUuo/+bwfdzTtG9RFIXiucm tDX5/lYrhSAEGuZP1RQ83lWlr7NF2p7t8CzcbD6YbpjHlKIOXz0UPorGOetnRYMd jnoZYQ7w0XA2yr5vd/k8idqNGDoApCKYoqb3PPA6eedKDE4+S37GU+n2cMcIdmBa meF3VmQsqocsxBLzCtzqO+PwerteUNwXb+IEnBFevVP0swwNh+IkVZgDJb85mt4C JhndgXkHGl18AC/+JAI9ayrT45QLI7Y2JfYj/3N8yfFKnTOMCcmLb8QdRuQM+g5V nkWEbEkTcZ3ZgR8q3YRGcapauHEspt1O47v00pg0zj+W0GcVu3/bp7jvlGyRJZc= =XytK -----END PGP SIGNATURE----- --oPjontER8dmrwkTB8jwbrn1T5kRF0VWvx--