From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757514AbaFSHkf (ORCPT ); Thu, 19 Jun 2014 03:40:35 -0400 Received: from top.free-electrons.com ([176.31.233.9]:57746 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755362AbaFSHkd (ORCPT ); Thu, 19 Jun 2014 03:40:33 -0400 Message-ID: <53A293E3.6000707@free-electrons.com> Date: Thu, 19 Jun 2014 09:40:19 +0200 From: Boris BREZILLON User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Bo Shen CC: Thierry Reding , Nicolas Ferre , David Airlie , Samuel Ortiz , Lee Jones , devicetree@vger.kernel.org, Jean-Jacques Hiblot , linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Alexandre Belloni , Laurent Pinchart , Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/7] ARM: at91/dt: split sama5d3 lcd pin definitions to match RGB mode configs References: <1402329860-27520-1-git-send-email-boris.brezillon@free-electrons.com> <1402329860-27520-5-git-send-email-boris.brezillon@free-electrons.com> <53A28C2C.1010001@atmel.com> In-Reply-To: <53A28C2C.1010001@atmel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Bo, On 19/06/2014 09:07, Bo Shen wrote: > Hi Boris, > > On 06/10/2014 12:04 AM, Boris BREZILLON wrote: >> The HLCDC (High LCD Controller) IP supports 4 different output mode >> (RGB444, RGB565, RGB666 and RGB888) and the pin muxing depends on the >> chosen RGB mode. >> >> Split the pin definition to be able to set the pin config according >> to the >> selected mode. >> >> Signed-off-by: Boris BREZILLON >> --- >> arch/arm/boot/dts/sama5d3_lcd.dtsi | 127 >> ++++++++++++++++++++++++++++--------- >> 1 file changed, 96 insertions(+), 31 deletions(-) > > On sama5d3xek board, it only works in 24bits output mode. And it > depends on the hardware design. So, I think only keep only one pinctrl > configuration. I'm not describing a specific board design but rather SoC capabilities (this dtsi is SoC related not board related), and the sama5d3 SoC supports 4 different RGB output modes through the RGB connector. If you take a look at patch 7, you'll see that I chose mode 3 (which is RGB888), and given this mode the HLCDC driver (atmel_hlcdc_panel.c) will request the appropriate pin state: atmel,panel = <&panel 3 0>; Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris BREZILLON) Date: Thu, 19 Jun 2014 09:40:19 +0200 Subject: [PATCH v2 4/7] ARM: at91/dt: split sama5d3 lcd pin definitions to match RGB mode configs In-Reply-To: <53A28C2C.1010001@atmel.com> References: <1402329860-27520-1-git-send-email-boris.brezillon@free-electrons.com> <1402329860-27520-5-git-send-email-boris.brezillon@free-electrons.com> <53A28C2C.1010001@atmel.com> Message-ID: <53A293E3.6000707@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Bo, On 19/06/2014 09:07, Bo Shen wrote: > Hi Boris, > > On 06/10/2014 12:04 AM, Boris BREZILLON wrote: >> The HLCDC (High LCD Controller) IP supports 4 different output mode >> (RGB444, RGB565, RGB666 and RGB888) and the pin muxing depends on the >> chosen RGB mode. >> >> Split the pin definition to be able to set the pin config according >> to the >> selected mode. >> >> Signed-off-by: Boris BREZILLON >> --- >> arch/arm/boot/dts/sama5d3_lcd.dtsi | 127 >> ++++++++++++++++++++++++++++--------- >> 1 file changed, 96 insertions(+), 31 deletions(-) > > On sama5d3xek board, it only works in 24bits output mode. And it > depends on the hardware design. So, I think only keep only one pinctrl > configuration. I'm not describing a specific board design but rather SoC capabilities (this dtsi is SoC related not board related), and the sama5d3 SoC supports 4 different RGB output modes through the RGB connector. If you take a look at patch 7, you'll see that I chose mode 3 (which is RGB888), and given this mode the HLCDC driver (atmel_hlcdc_panel.c) will request the appropriate pin state: atmel,panel = <&panel 3 0>; Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com