From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxcpE-0004MP-Fm for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:56:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wxcp5-0002QB-Ug for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:56:24 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:48796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxcp5-0002Ps-JI for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:56:15 -0400 Received: by mail-pb0-f46.google.com with SMTP id md12so1943263pbc.19 for ; Thu, 19 Jun 2014 06:56:13 -0700 (PDT) Message-ID: <53A2EBF8.1090907@ozlabs.ru> Date: Thu, 19 Jun 2014 23:56:08 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1401442460-32648-1-git-send-email-aik@ozlabs.ru> <1401442460-32648-9-git-send-email-aik@ozlabs.ru> <538DCB4C.4040905@ozlabs.ru> <5393A77C.80202@ozlabs.ru> <5399C112.2090205@ozlabs.ru> <5399DBDD.3050101@suse.de> In-Reply-To: <5399DBDD.3050101@suse.de> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 8/9] vmstate: Add preallocation for migrating arrays (VMS_ALLOC flag) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Peter Maydell , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Juan Quintela On 06/13/2014 02:57 AM, Alexander Graf wrote: > On 06/12/2014 05:02 PM, Alexey Kardashevskiy wrote: >> On 06/08/2014 09:59 AM, Alexey Kardashevskiy wrote: >>> On 06/03/2014 11:19 PM, Alexey Kardashevskiy wrote: >>>> On 05/30/2014 07:34 PM, Alexey Kardashevskiy wrote: >>>>> There are few helpers already to support array migration. However they >>>>> all >>>>> require the destination side to preallocate arrays before migration which >>>>> is not always possible due to unknown array size as it might be some >>>>> sort of dynamic state. One of the examples is an array of MSIX-enabled >>>>> devices in SPAPR PHB - this array may vary from 0 to 65536 entries and >>>>> its size depends on guest's ability to enable MSIX or do PCI hotplug. >>>>> >>>>> This adds new VMSTATE_VARRAY_STRUCT_ALLOC macro which is pretty >>>>> similar to >>>>> VMSTATE_STRUCT_VARRAY_POINTER_INT32 but it can alloc memory for migratign >>>>> array on the destination side. >>>>> >>>>> This defines VMS_ALLOC flag for a field. >>>>> >>>>> This changes vmstate_base_addr() to do the allocation when receiving >>>>> migration. >>>> >>>> >>>> Juan, Peter? No hurry, just pinging in order not to forget :) Thanks! >>> >>> Hi, anyone? :) >> >> Ping? > > Acked-by: Alexander Graf This is cool and thanks :) But we still need to attract attention of others... -- Alexey