From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Billauer Date: Thu, 19 Jun 2014 19:50:47 +0300 Subject: [U-Boot] [PATCH] mmc: sdhci: Fixed timeout for sdhci_send_command() In-Reply-To: References: <1402566069-8061-1-git-send-email-eli.billauer@gmail.com> <1402566069-8061-2-git-send-email-eli.billauer@gmail.com> Message-ID: <53A314E7.3020507@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 19/06/14 19:43, Andy Fleming wrote: > On Thu, Jun 12, 2014 at 4:41 AM, Eli Billauer wrote: > >> The current wait loop just reads the status 10000 times, which makes the >> actual timeout period platform-dependent. The udelay() call within the loop >> makes the new timeout ~100 ms. >> >> [ snipped patch ] >> > > Hmmm... > > Is 100ms part of the spec? I like the idea of making the timeout more > time-based, but it seems to me that this changes the timeout quite > significantly. If it took N ms before, it now takes N + 100 ms. > > I think, if we want the timeout to be ~100ms, we should use a udelay > of 100 or 1000, and then reduce "retry" accordingly. > Hi, As I said in the mail preceding this patch, I don't know what the timeout should be. Maybe someone with a better knowledge on MMC could come forward. Regards, Eli > Andy > >