From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxfdS-0006Bf-3F for qemu-devel@nongnu.org; Thu, 19 Jun 2014 12:56:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxfdM-0007HI-VY for qemu-devel@nongnu.org; Thu, 19 Jun 2014 12:56:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxfdM-0007HA-My for qemu-devel@nongnu.org; Thu, 19 Jun 2014 12:56:20 -0400 Message-ID: <53A31630.1000902@redhat.com> Date: Thu, 19 Jun 2014 10:56:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <53A0C057.6000205@redhat.com> In-Reply-To: <53A0C057.6000205@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2Q0BeLR5fc58hL5fBhihFTie5JPFaUV1L" Subject: Re: [Qemu-devel] [PATCH v6 for 2.1 04/10] block: make 'top' argument to block-commit optional List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, pkrempa@redhat.com, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2Q0BeLR5fc58hL5fBhihFTie5JPFaUV1L Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/17/2014 04:25 PM, Eric Blake wrote: > On 06/17/2014 03:53 PM, Jeff Cody wrote: >> Now that active layer block-commit is supported, the 'top' argument >> no longer needs to be mandatory. >> >> Change it to optional, with the default being the active layer in the >> device chain. >> >> Reviewed-by: Eric Blake >> Reviewed-by: Benoit Canet >> Signed-off-by: Jeff Cody >> --- >=20 > As mentioned elsewhere, this is the patch that changed from v5. But so= > there's no confusion, I've gone back over this one, and my R-b still st= ands. >=20 >> + /* Important Note: >> + * libvirt relies on the DeviceNotFound error class in order to = probe for >> + * live commit feature versions; for this to work, we must make = sure to >> + * perform the device lookup before any generic errors that may = occur in a >> + * scenario in which all optional arguments are omitted. */ >> bs =3D bdrv_find(device); >> if (!bs) { >> error_set(errp, QERR_DEVICE_NOT_FOUND, device); >=20 > Thanks for adding the comment :) >=20 Should we split this into a different series, since it is non-controversial (unrelated to the rest of the series' impact on child-node op-blockers), and useful for libvirt to turn on active commit? The rest of the series lets libvirt turn on relative backing chain work, but we might as well get the easy part into the tree now. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2Q0BeLR5fc58hL5fBhihFTie5JPFaUV1L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJToxYwAAoJEKeha0olJ0NqSgcH/0Yzt0tbqYcJmLoapjPNiOIE 3inWr7Njxeumnc1Wul8jWEg3pOKtTTT2rIcRVY5Af8XhkWRV5JxZqoVo6TebuCTt v/PDVowKwo7VaXRVLjE6D+W2cgkAWflpppvjvwyNGKZ/ZfxlwYG1SP4taKI8Gu5K dZZHKQfJVMUbqBMzzeZITHEhGOPnlmEev7S5SvCbUzHTmwrA7owAR/EaqyBRdFBA +QJF4erMoM00IVAFreaiclYxATbanSiXY0ZdkDEVYmdexOiPARSVPzST9fkT15XM 9y/0MqnerabX0d4vAUboHS6Jf80uTS81NJXzfp3cUE4IrAXTnOfVl2lvfoptE1U= =WCWF -----END PGP SIGNATURE----- --2Q0BeLR5fc58hL5fBhihFTie5JPFaUV1L--