From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxq8w-0003ga-5e for qemu-devel@nongnu.org; Fri, 20 Jun 2014 00:09:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wxq8n-0005QC-5G for qemu-devel@nongnu.org; Fri, 20 Jun 2014 00:09:38 -0400 Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:36007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxq8n-0005Q8-0a for qemu-devel@nongnu.org; Fri, 20 Jun 2014 00:09:29 -0400 Received: by mail-qc0-f182.google.com with SMTP id m20so3002913qcx.41 for ; Thu, 19 Jun 2014 21:09:28 -0700 (PDT) Sender: Richard Henderson Message-ID: <53A3B3F4.5040907@twiddle.net> Date: Thu, 19 Jun 2014 21:09:24 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1402499992-64851-1-git-send-email-leon.alrae@imgtec.com> <1402499992-64851-22-git-send-email-leon.alrae@imgtec.com> <20140619221830.GA14303@ohm.rr44.fr> In-Reply-To: <20140619221830.GA14303@ohm.rr44.fr> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 21/22] target-mips: use pointers referring to appropriate decoding function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , Leon Alrae Cc: yongbok.kim@imgtec.com, cristian.cuna@imgtec.com, qemu-devel@nongnu.org On 06/19/2014 03:18 PM, Aurelien Jarno wrote: > I have mixed filling about that. While it clearly makes the code more > readable, I am not sure it would be any faster given that it might kill > branch prediction. Any opinion from others? Given the function pointer is used only once, I don't think it's useful. With normal branch predictors we'll do much better with direct branches, and probably inlining. r~