From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxtQ7-0006Ji-1L for qemu-devel@nongnu.org; Fri, 20 Jun 2014 03:39:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxtPy-0006nQ-1P for qemu-devel@nongnu.org; Fri, 20 Jun 2014 03:39:34 -0400 Sender: Paolo Bonzini Message-ID: <53A3E515.10400@redhat.com> Date: Fri, 20 Jun 2014 09:39:01 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1401884936-12907-1-git-send-email-agraf@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] Platform device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Alexander Graf Cc: qemu-ppc Mailing List , "qemu-devel@nongnu.org Developers" , Eric Auger Il 20/06/2014 08:43, Peter Crosthwaite ha scritto: > I think a big point of confusion here is you have picked a > not-even-qdevified device for conversion. Boards are still calling > serial_mm_init() directly due to lack of a proper device for Sysbus > serial. > > Do you have another device that already QOMified (a MAC or something > perhaps?) that you can convert more minimally to demonstrate the > approach for existing sysbus devs? > > Sysbusification of serial would then be a step towards platform-device serial. Indeed, I would first start with patches that make serial_mm_init a sysbus wrapper. Then, with techniques similar to Peter's work, it should be possible to extend -device and do something like -device serial-mmio,memory.addr=0x1f000000,irq=gpio[5] or something like that. The only difference is whether you get the information from device tree or command line. Paolo