From mboxrd@z Thu Jan 1 00:00:00 1970 From: Deepak S Subject: Re: [PATCH] drm/i915: Restrict GPU boost to the RCS engine Date: Sat, 21 Jun 2014 08:43:13 +0530 Message-ID: <53A4F849.1010201@linux.intel.com> References: <1402565335-1759-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F51B6E1AE for ; Thu, 19 Jun 2014 20:18:49 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Chris Wilson Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Thursday 12 June 2014 03:02 PM, Daniel Vetter wrote: > Adding Deepak for testing, this hopefully alleviates the bad > side-effects of the gpu booster he's seeing. > -Daniel > > On Thu, Jun 12, 2014 at 11:28 AM, Chris Wilson wrote: >> Make the assumption that media workloads are not as latency sensitive >> for __wait_seqno, and that upclocking the GPU does not affect the BLT >> engine. Under that assumption, we only wait to forcibly upclock the GPU >> when we are stalling for results from the render pipeline. >> >> Signed-off-by: Chris Wilson >> --- >> drivers/gpu/drm/i915/i915_gem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c >> index 5951618a6b08..242b595a0403 100644 >> --- a/drivers/gpu/drm/i915/i915_gem.c >> +++ b/drivers/gpu/drm/i915/i915_gem.c >> @@ -1409,7 +1409,7 @@ static int __wait_seqno(struct intel_engine_cs *ring, u32 seqno, >> >> timeout_expire = timeout ? jiffies + timespec_to_jiffies_timeout(timeout) : 0; >> >> - if (INTEL_INFO(dev)->gen >= 6 && can_wait_boost(file_priv)) { >> + if (INTEL_INFO(dev)->gen >= 6 && ring->id == RCS && can_wait_boost(file_priv)) { >> gen6_rps_boost(dev_priv); >> if (file_priv) >> mod_delayed_work(dev_priv->wq, >> -- >> 2.0.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > Thanks Daniel. Apologies for delayed response. Yup the changes make sense. I will test and share the results.