All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: kwolf@redhat.com, stefanha@redhat.com, Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable
Date: Sat, 21 Jun 2014 21:00:44 +0800	[thread overview]
Message-ID: <53A581FC.6050305@gmail.com> (raw)

'buf' is not used actually, so remove it and related snprintf() statement.


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 block.c | 2 --
 dtc     | 1 -
 2 files changed, 3 deletions(-)
 delete mode 160000 dtc

diff --git a/block.c b/block.c
index 43abe96..74af8d7 100644
--- a/block.c
+++ b/block.c
@@ -5595,7 +5595,6 @@ void bdrv_img_create(const char *filename, const char *fmt,
         if (backing_file) {
             BlockDriverState *bs;
             uint64_t size;
-            char buf[32];
             int back_flags;
 
             /* backing files always opened read-only */
@@ -5616,7 +5615,6 @@ void bdrv_img_create(const char *filename, const char *fmt,
             bdrv_get_geometry(bs, &size);
             size *= 512;
 
-            snprintf(buf, sizeof(buf), "%" PRId64, size);
             qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size);
 
             bdrv_unref(bs);
diff --git a/dtc b/dtc
deleted file mode 160000
index bc895d6..0000000
--- a/dtc
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit bc895d6d09695d05ceb8b52486ffe861d6cfbdde
-- 
1.7.11.7

             reply	other threads:[~2014-06-21 13:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-21 13:00 Chen Gang [this message]
2014-06-21 15:03 ` [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable Michael Tokarev
2014-06-22  2:03   ` Chen Gang
2014-06-23 13:37 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A581FC.6050305@gmail.com \
    --to=gang.chen.5i5j@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.