From mboxrd@z Thu Jan 1 00:00:00 1970 From: karthik.188@gmail.com (karthik) Date: Sat, 21 Jun 2014 20:12:10 +0530 Subject: Are Small Changes in kernel accepted as patches In-Reply-To: <26608.1403360621@turing-police.cc.vt.edu> References: <53A5526D.9010702@gmail.com> <26608.1403360621@turing-police.cc.vt.edu> Message-ID: <53A599C2.5000402@gmail.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On Saturday 21 June 2014 07:53 PM, Valdis.Kletnieks at vt.edu wrote: > On Sat, 21 Jun 2014 15:07:49 +0530, karthik said: > >> I was just going through the linux-next source and found a small change >> in one of the files. (Unnecessary else) > One-line patches that fix misleading logic are always welcome. > > Just remember to: > > 1_ Read Documentation/SubmititingPatches.txt and follow the directions > > 2) In the patch description/ changelog explain *why* the 'else' is unneeded > as that's a change in the program logic. And then fix it correctly - if > the else is unneeded because you can prove it's deal code because the > if condition is always true, then the 'if then' part can probably be > fixed up as well.... Brilliant Thanks for the replies