* [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable
@ 2014-06-21 13:00 Chen Gang
2014-06-21 15:03 ` Michael Tokarev
2014-06-23 13:37 ` Kevin Wolf
0 siblings, 2 replies; 4+ messages in thread
From: Chen Gang @ 2014-06-21 13:00 UTC (permalink / raw)
To: kwolf, stefanha, Michael Tokarev; +Cc: qemu-trivial, qemu-devel
'buf' is not used actually, so remove it and related snprintf() statement.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
block.c | 2 --
dtc | 1 -
2 files changed, 3 deletions(-)
delete mode 160000 dtc
diff --git a/block.c b/block.c
index 43abe96..74af8d7 100644
--- a/block.c
+++ b/block.c
@@ -5595,7 +5595,6 @@ void bdrv_img_create(const char *filename, const char *fmt,
if (backing_file) {
BlockDriverState *bs;
uint64_t size;
- char buf[32];
int back_flags;
/* backing files always opened read-only */
@@ -5616,7 +5615,6 @@ void bdrv_img_create(const char *filename, const char *fmt,
bdrv_get_geometry(bs, &size);
size *= 512;
- snprintf(buf, sizeof(buf), "%" PRId64, size);
qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size);
bdrv_unref(bs);
diff --git a/dtc b/dtc
deleted file mode 160000
index bc895d6..0000000
--- a/dtc
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit bc895d6d09695d05ceb8b52486ffe861d6cfbdde
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable
2014-06-21 13:00 [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable Chen Gang
@ 2014-06-21 15:03 ` Michael Tokarev
2014-06-22 2:03 ` Chen Gang
2014-06-23 13:37 ` Kevin Wolf
1 sibling, 1 reply; 4+ messages in thread
From: Michael Tokarev @ 2014-06-21 15:03 UTC (permalink / raw)
To: Chen Gang, kwolf, stefanha; +Cc: qemu-trivial, qemu-devel
21.06.2014 17:00, Chen Gang wrote:
> 'buf' is not used actually, so remove it and related snprintf() statement.
Applied to -trivial, after removing wrong reference to dtc submodule removal.
Please don't include these in diffs.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable
2014-06-21 15:03 ` Michael Tokarev
@ 2014-06-22 2:03 ` Chen Gang
0 siblings, 0 replies; 4+ messages in thread
From: Chen Gang @ 2014-06-22 2:03 UTC (permalink / raw)
To: Michael Tokarev, kwolf, stefanha; +Cc: qemu-trivial, qemu-devel
On 06/21/2014 11:03 PM, Michael Tokarev wrote:
> 21.06.2014 17:00, Chen Gang wrote:
>> 'buf' is not used actually, so remove it and related snprintf() statement.
>
> Applied to -trivial, after removing wrong reference to dtc submodule removal.
> Please don't include these in diffs.
>
OK, thanks, I shall notice about it, next time.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable
2014-06-21 13:00 [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable Chen Gang
2014-06-21 15:03 ` Michael Tokarev
@ 2014-06-23 13:37 ` Kevin Wolf
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2014-06-23 13:37 UTC (permalink / raw)
To: Chen Gang; +Cc: qemu-trivial, Michael Tokarev, qemu-devel, stefanha
Am 21.06.2014 um 15:00 hat Chen Gang geschrieben:
> 'buf' is not used actually, so remove it and related snprintf() statement.
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-23 13:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-21 13:00 [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable Chen Gang
2014-06-21 15:03 ` Michael Tokarev
2014-06-22 2:03 ` Chen Gang
2014-06-23 13:37 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.