From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57960)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WyRi2-00047u-DZ
	for qemu-devel@nongnu.org; Sat, 21 Jun 2014 16:16:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WyRht-0005yn-6F
	for qemu-devel@nongnu.org; Sat, 21 Jun 2014 16:16:22 -0400
Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:35402)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WyRht-0005yj-2o
	for qemu-devel@nongnu.org; Sat, 21 Jun 2014 16:16:13 -0400
Received: by mail-qg0-f49.google.com with SMTP id f51so4586234qge.36
	for <qemu-devel@nongnu.org>; Sat, 21 Jun 2014 13:16:12 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53A5E808.4090309@twiddle.net>
Date: Sat, 21 Jun 2014 13:16:08 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1403355502-12288-1-git-send-email-pbonzini@redhat.com>
	<1403355502-12288-12-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1403355502-12288-12-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 11/11] target-arm: implement BE32 mode
 in system emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org

On 06/21/2014 05:58 AM, Paolo Bonzini wrote:
> @@ -855,32 +878,68 @@ static inline void gen_aa32_ld64(DisasContext *s, TCGv_i64 val, TCGv_i32 addr, i
>  {
>      TCGMemOp opc = MO_Q | s->mo_endianness;
>      tcg_gen_qemu_ld_i64(val, addr, index, opc);
> +#ifndef CONFIG_USER_ONLY
> +    /* Not needed for user-mode BE32 emulation, where we use MO_BE
> +     * instead.
> +     */
> +    if (s->sctlr_b) {
> +        tcg_gen_rotri_i32(val, val, 32);

_i64.  Would have been caught with --enable-debug-tcg.


r~